Support non-posted MMIO on arm64 with FDT
ClosedPublic
Actions

Authored by andrew on Feb 21 2022, 4:52 PM.

Details

Reviewers

manu
kevans

Commits

rG5a91529479b4: Support non-posted MMIO on arm64 with FDT

Summary

To allow hardware to work around a broken memory bus where we need to
support the nonposted-mmio flag.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Feb 21 2022, 4:52 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 21 2022, 4:52 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B44529: Diff 103068.Feb 21 2022, 4:52 PM

andrew requested review of this revision.Feb 21 2022, 4:52 PM

Just a very minor notice . Wouldn't it be better to name the VM memory attribute by function, not by type? Different architectures may have different attribute mapping requirements for the PCI configuration space, and something like a global VM_MEMATTR_PCI_CONFIG (may be aliased to platform specific VM_MEMATTR_DEVICE_NP on arm64) gives us a much better chance of having cross-platform drivers without #ifdef hell.

Stop using ofw_bus_has_prop. It's wrong when the parent isn't an ofw bus.

Harbormaster completed remote builds in B44533: Diff 103092.Feb 22 2022, 12:40 PM

andrew mentioned this in D38895: arm64: use non-posted device memory if nonposted-mmio is set.Mar 3 2023, 5:23 PM

kevans accepted this revision.Mar 3 2023, 8:56 PM

This revision is now accepted and ready to land.Mar 3 2023, 8:56 PM

andrew mentioned this in D30079: Map arm64 pci config memory as non-posted.Mar 3 2023, 10:52 PM

Closed by commit rG5a91529479b4: Support non-posted MMIO on arm64 with FDT (authored by andrew). · Explain WhyMar 5 2023, 8:28 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG5a91529479b4: Support non-posted MMIO on arm64 with FDT.