Differential D33595

ipfilter Ansification: Convert K&R function declarations to ANSI
ClosedPublic
Actions

Authored by cy on Dec 20 2021, 10:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 8:23 PM

	Unknown Object (File)
	Tue, Nov 12, 12:26 AM

	Unknown Object (File)
	Sun, Nov 10, 9:26 PM

	Unknown Object (File)
	Sun, Nov 10, 2:39 PM

	Unknown Object (File)
	Sun, Nov 10, 2:10 PM

	Unknown Object (File)
	Sun, Nov 10, 1:56 PM

	Unknown Object (File)
	Sat, Nov 9, 2:48 AM

	Unknown Object (File)
	Fri, Nov 8, 7:43 AM

View All 44 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG4e8d52e7d72e: ipflter: ANSIfy kernel function declarations
rG94dcd62056e9: ipflter: ANSIfy kernel function declarations
rG064a5a95649d: ipflter: ANSIfy kernel function declarations
rG39353bb1609f: ipflter: ANSIfy userland function declarations
rG9ff592d86890: ipflter: ANSIfy userland function declarations
rGefeb8bffe344: ipflter: ANSIfy userland function declarations

Summary

Convert ipfilter kernel function declarations from K&R to ANSI. This syncs our function declarations with NetBSD hg commit 75edcd7552a0 (apply our changes). Though not copied from NetBSD, this change was partially inspired by NetBSD's work and inspired by style(9).

Test Plan

Currently running here.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cy created this revision.Dec 20 2021, 10:37 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptDec 20 2021, 10:37 PM

cy requested review of this revision.Dec 20 2021, 10:37 PM

A copy can be found on github (https://github.com/cschuber/freebsd-ipf-ansi).

The uppercase INLINE, which I guess is a macro, can be substituted to lowercase inline, which is part of modern C in the same sweep.

P.S. IMHO such mechanical sweeps don't deserve a publication of review and don't require reviewers.

This revision is now accepted and ready to land.Dec 21 2021, 3:51 PM

Thanks. INLINE --> inline should be a separate pair of commits.

Also planned is conform "return" statements to style(9).

Closed by commit rGefeb8bffe344: ipflter: ANSIfy userland function declarations (authored by cy). · Explain WhyJan 4 2022, 2:08 AM

This revision was automatically updated to reflect the committed changes.

cy added a commit: rGefeb8bffe344: ipflter: ANSIfy userland function declarations.

cy added a commit: rG9ff592d86890: ipflter: ANSIfy userland function declarations.Feb 7 2022, 1:53 PM

cy added a commit: rG39353bb1609f: ipflter: ANSIfy userland function declarations.Feb 7 2022, 1:56 PM

cy added a commit: rG064a5a95649d: ipflter: ANSIfy kernel function declarations.Nov 8 2022, 3:56 AM

cy added a commit: rG94dcd62056e9: ipflter: ANSIfy kernel function declarations.Oct 13 2023, 3:50 AM

cy added a commit: rG4e8d52e7d72e: ipflter: ANSIfy kernel function declarations.Nov 17 2023, 8:13 AM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfilter/

netinet/

664 lines

86 lines

50 lines

128 lines

ip_fil_freebsd.c

79 lines

136 lines

154 lines

153 lines

36 lines

25 lines

57 lines

103 lines

388 lines

145 lines

ip_netbios_pxy.c

10 lines

150 lines

45 lines

88 lines

ip_raudio_pxy.c

22 lines

34 lines

113 lines

12 lines

43 lines

240 lines

98 lines

52 lines

26 lines

110 lines

Diff 100378

sys/netpfil/ipfilter/netinet/fil.c

Loading...

sys/netpfil/ipfilter/netinet/ip_auth.c

Loading...

sys/netpfil/ipfilter/netinet/ip_dns_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_dstlist.c

Loading...

sys/netpfil/ipfilter/netinet/ip_fil_freebsd.c

Loading...

sys/netpfil/ipfilter/netinet/ip_frag.c

Loading...

sys/netpfil/ipfilter/netinet/ip_ftp_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_htable.c

Loading...

sys/netpfil/ipfilter/netinet/ip_ipsec_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_irc_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_log.c

Loading...

sys/netpfil/ipfilter/netinet/ip_lookup.c

Loading...

sys/netpfil/ipfilter/netinet/ip_nat.c

Loading...

sys/netpfil/ipfilter/netinet/ip_nat6.c

Loading...

sys/netpfil/ipfilter/netinet/ip_netbios_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_pool.c

Loading...

sys/netpfil/ipfilter/netinet/ip_pptp_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_proxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_raudio_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_rcmd_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_rpcb_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/ip_rules.c

Loading...

sys/netpfil/ipfilter/netinet/ip_scan.c

Loading...

sys/netpfil/ipfilter/netinet/ip_state.c

Loading...

sys/netpfil/ipfilter/netinet/ip_sync.c

Loading...

sys/netpfil/ipfilter/netinet/ip_tftp_pxy.c

Loading...

sys/netpfil/ipfilter/netinet/mlfk_ipl.c

Loading...

sys/netpfil/ipfilter/netinet/radix_ipf.c

Loading...