Paths

Table of Contentst

Differential D32321

Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller.
ClosedPublic
Actions

Authored by ray on Oct 5 2021, 3:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 1, 5:22 AM

	Unknown Object (File)
	Wed, Oct 29, 7:50 AM

	Unknown Object (File)
	Mon, Oct 27, 7:00 PM

	Unknown Object (File)
	Mon, Oct 27, 6:57 AM

	Unknown Object (File)
	Sat, Oct 25, 1:50 AM

	Unknown Object (File)
	Sun, Oct 19, 7:54 AM

	Unknown Object (File)
	Sun, Oct 19, 7:27 AM

	Unknown Object (File)
	Sun, Oct 12, 1:58 AM

Subscribers

Details

Reviewers

manu
mhorne
gnn

Group Reviewers

Commits

rG59191f3573f6: Add support of ARM CMN-600 controller, PMU access functions only. Add support…

Summary

Add support of ARM CMN-600 controller, PMU access functions only.
Add support of PMU counters of ARM CMN-600 controller.

Sponsored By: ARM

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41969
Build 38857: arc lint + arc unit

Event Timeline

ray created this revision.Oct 5 2021, 3:10 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 5 2021, 3:10 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

ray requested review of this revision.Oct 5 2021, 3:10 PM

Harbormaster completed remote builds in B41969: Diff 96276.Oct 5 2021, 3:11 PM

ray edited the summary of this revision. (Show Details)Oct 5 2021, 3:12 PM

ray added reviewers: pmc, mhorne.

allanjude added a subscriber: allanjude.Oct 5 2021, 3:25 PM

andrew added inline comments.Oct 5 2021, 4:01 PM

sys/arm64/arm64/cmn600.c
59	Is this used?
339	There's no need to case the return value of malloc.
347–350	Why are these function pointers?
390–398	What are these magic numbers?
sys/dev/hwpmc/hwpmc_cmn600.c
422–424	What are these magic numbers?
818	No need for this, `KASSERT` handles `INVARIANTS` not being defined.

Is this missing a change to attach these files to the build?

A few minor comments, I've looked mainly at hwpmc_cmn600.c so far.

sys/arm64/arm64/cmn600.c
69	What does this do?
70	cleanup the RF_SHAREABLE if not needed.
sys/dev/hwpmc/hwpmc_cmn600.c
50–58	At least a couple of these fields appear to be unused.
62	Is `cmn600_pmcdesc[1]` ever used? I don't see it.
65	From its usage it looks like this holds the number of cmn600 units in the system? If so `cmn600_nunits` would be a clearer name.
68	unused `cpu` argument?
94	Please use named macros for this kind of thing. It is impossible to tell what this bit means.
163
354–355	This check is not needed, I removed the others in R10:0e78510b7549.
383–389	Does these comments apply?
485	?
728	`cmn600_pmc_nunits()` expands to `return (cmn600_npmcs)`... so what is this assignment?

allanjude edited the summary of this revision. (Show Details)Oct 20 2021, 11:39 PM

Done comments.

Harbormaster completed remote builds in B42423: Diff 97636.Oct 28 2021, 10:25 PM

ray added inline comments.Oct 28 2021, 10:29 PM

sys/arm64/arm64/cmn600.c
59	Removed. Thanks!
69	First include second. Second only used to calculate offset, so no need to map it. Thanks
70	Done. Thanks!
339	Done. Thanks!
347–350	OOP like mode :) At least names are shorter on usage.
390–398	Done. Thanks!
sys/dev/hwpmc/hwpmc_cmn600.c
50–58	Done. Thanks!
62	Copy-paste :) Fixed. Thanks!
422–424	They are indeed magic :) I've add a comment to describe magicness: Calculate pmevcnt0_input_sel based on list in Table 3-794.
485	Ahh, it is steps taken from manual. First one done in HW side. Comment updated.
728	It's an external call from hwpmc_cmn600 to cmn600 driver :) cmn600_npmcs static in both cases.

ray added inline comments.Oct 28 2021, 10:35 PM

sys/dev/hwpmc/hwpmc_cmn600.c
68	Removed. Thanks!
94	Done. Thanks!
163	Done. Thanks!
354–355	Done. Thanks!
383–389	Done. Thanks!
818	Done. Thanks!

mhorne accepted this revision.Nov 23 2021, 7:42 PM

mhorne added inline comments.

sys/dev/hwpmc/hwpmc_cmn600.c
493–494

This revision is now accepted and ready to land.Nov 23 2021, 7:42 PM

allanjude added a subscriber: gallatin.Feb 10 2022, 4:40 PM

Closed by commit rG59191f3573f6: Add support of ARM CMN-600 controller, PMU access functions only. Add support… (authored by ray, committed by tsoome). · Explain WhyJun 26 2022, 10:28 PM

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rG59191f3573f6: Add support of ARM CMN-600 controller, PMU access functions only. Add support….

Herald added a reviewer: gnn. · View Herald TranscriptJun 26 2022, 10:28 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

836 lines

dev/

hwpmc/

835 lines

Diff 96276

sys/arm64/arm64/cmn600.c

Loading...

sys/dev/hwpmc/hwpmc_cmn600.c

Loading...