Page MenuHomeFreeBSD

tcp: avoid useless calculations in tcp_account_for_send() when len is 0
ClosedPublic

Authored by gallatin on Sep 14 2021, 2:54 PM.
Tags
None
Referenced Files
F166168593: D31959.diff
Wed, Aug 12, 1:27 AM
Unknown Object (File)
Tue, Aug 11, 10:30 PM
Unknown Object (File)
Mon, Aug 10, 12:03 PM
Unknown Object (File)
Mon, Aug 10, 12:02 PM
Unknown Object (File)
Mon, Aug 10, 12:01 PM
Unknown Object (File)
Mon, Aug 10, 11:37 AM
Unknown Object (File)
Mon, Aug 10, 7:43 AM
Unknown Object (File)
Sun, Aug 9, 3:20 AM
Subscribers

Details

Summary

When the length is 0, the retransmit rate could not have changed, so avoid doing math to determine if we need to move a TLS connection from hardware to software.

This also fixes a potential bug when switching from an old or buggy TCP stack which does not call into tcp_account_for_send(). In this case, the first call into tcp_account_for_send() will find the t_sndbytes and t_snd_rxt_bytes as 0, and if that first call is for a rexmit, we'll hit a divide-by-zero bug unless we guard against a zero length.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable