Page MenuHomeFreeBSD

tcp: avoid useless calculations in tcp_account_for_send() when len is 0
ClosedPublic

Authored by gallatin on Tue, Sep 14, 2:54 PM.

Details

Summary

When the length is 0, the retransmit rate could not have changed, so avoid doing math to determine if we need to move a TLS connection from hardware to software.

This also fixes a potential bug when switching from an old or buggy TCP stack which does not call into tcp_account_for_send(). In this case, the first call into tcp_account_for_send() will find the t_sndbytes and t_snd_rxt_bytes as 0, and if that first call is for a rexmit, we'll hit a divide-by-zero bug unless we guard against a zero length.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.