Paths

Table of Contentst

Differential D31477

Enable SError exceptions in the kernel
ClosedPublic
Actions

Authored by andrew on Aug 9 2021, 5:00 PM.

Tags

None

Referenced Files

	F135602450: D31477.id.diff
	Tue, Nov 11, 5:26 AM

	Unknown Object (File)
	Sun, Nov 9, 4:36 AM

	Unknown Object (File)
	Thu, Nov 6, 7:17 AM

	Unknown Object (File)
	Tue, Nov 4, 2:59 AM

	Unknown Object (File)
	Wed, Oct 29, 5:13 PM

	Unknown Object (File)
	Wed, Oct 29, 5:12 PM

	Unknown Object (File)
	Wed, Oct 29, 5:10 PM

	Unknown Object (File)
	Fri, Oct 24, 9:49 AM

Subscribers

Details

Reviewers

kib
markj
mhorne
manu

Group Reviewers

Commits

rG9a83fcad145c: Enable arm64 SError exceptions in the kernel
rG17b6ee961382: Enable arm64 SError exceptions in the kernel

Summary

These are needed to signal to the kernel when a Reliability,
Availability, and Serviceability (RAS) exception has triggered.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Aug 9 2021, 5:00 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 9 2021, 5:00 PM

Herald added a subscriber: imp. · View Herald Transcript

andrew requested review of this revision.Aug 9 2021, 5:00 PM

Harbormaster completed remote builds in B40948: Diff 93447.Aug 9 2021, 5:00 PM

mhorne added inline comments.Aug 9 2021, 5:46 PM

sys/arm64/arm64/exception.S
86–88	Can an SError interrupt be taken from EL1? If so, I think you need to unmask DAIF_A here or in do_el1h_sync().
sys/arm64/arm64/machdep.c
939	Maybe add `serror_enable()` or similar to cpufunc.h and use that?

Unmask in the kernel
Add serror_enable

Harbormaster completed remote builds in B40962: Diff 93480.Aug 10 2021, 10:43 AM

mhorne accepted this revision.Aug 11 2021, 2:57 PM

This revision is now accepted and ready to land.Aug 11 2021, 2:57 PM

Closed by commit rG17b6ee961382: Enable arm64 SError exceptions in the kernel (authored by andrew). · Explain WhyAug 12 2021, 8:53 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG17b6ee961382: Enable arm64 SError exceptions in the kernel.

andrew added a commit: rG9a83fcad145c: Enable arm64 SError exceptions in the kernel.Sep 27 2021, 2:09 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

24 lines

6 lines

4 lines

include/

8 lines

7 lines

Diff 93604

sys/arm64/arm64/exception.S

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/arm64/arm64/vm_machdep.c

Loading...

sys/arm64/include/armreg.h

Loading...

sys/arm64/include/cpufunc.h

Loading...