Page MenuHomeFreeBSD
Differential D31477

Enable SError exceptions in the kernel
ClosedPublic
Actions

Authored by andrew on Aug 9 2021, 5:00 PM.
Tags
None
Referenced Files
F144247408: D31477.diff
Sat, Feb 7, 2:11 AM
F144247405: D31477.diff
Sat, Feb 7, 2:11 AM
Unknown Object (File)
Thu, Jan 29, 1:26 PM
Unknown Object (File)
Thu, Jan 29, 1:26 PM
Unknown Object (File)
Sun, Jan 25, 1:29 AM
Unknown Object (File)
Mon, Jan 12, 7:47 AM
Unknown Object (File)
Dec 31 2025, 10:48 PM
Unknown Object (File)
Dec 29 2025, 6:27 AM
View All Files
Subscribers
emaste
imp
jhibbits

Details

Reviewers
kib
markj
mhorne
manu
Group Reviewers
arm64
Commits
rG9a83fcad145c: Enable arm64 SError exceptions in the kernel
rG17b6ee961382: Enable arm64 SError exceptions in the kernel
Summary

These are needed to signal to the kernel when a Reliability,
Availability, and Serviceability (RAS) exception has triggered.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Aug 9 2021, 5:00 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 9 2021, 5:00 PM
Herald added a subscriber: imp. · View Herald Transcript
andrew requested review of this revision.Aug 9 2021, 5:00 PM
Harbormaster completed remote builds in B40948: Diff 93447.Aug 9 2021, 5:00 PM
mhorne added inline comments.Aug 9 2021, 5:46 PM
sys/arm64/arm64/exception.S
86–88

Can an SError interrupt be taken from EL1? If so, I think you need to unmask DAIF_A here or in do_el1h_sync().

sys/arm64/arm64/machdep.c
939

Maybe add serror_enable() or similar to cpufunc.h and use that?

andrew updated this revision to Diff 93480.Aug 10 2021, 10:43 AM

Unmask in the kernel
Add serror_enable

Harbormaster completed remote builds in B40962: Diff 93480.Aug 10 2021, 10:43 AM
mhorne accepted this revision.Aug 11 2021, 2:57 PM
This revision is now accepted and ready to land.Aug 11 2021, 2:57 PM
Closed by commit rG17b6ee961382: Enable arm64 SError exceptions in the kernel (authored by andrew). · Explain WhyAug 12 2021, 8:53 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG17b6ee961382: Enable arm64 SError exceptions in the kernel.
andrew added a commit: rG9a83fcad145c: Enable arm64 SError exceptions in the kernel.Sep 27 2021, 2:09 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
24 lines
6 lines
4 lines
include/
8 lines
7 lines

Diff 93604

View Options

sys/arm64/arm64/exception.S

Loading...
View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/arm64/vm_machdep.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...
View Options

sys/arm64/include/cpufunc.h

Loading...