Differential D30924

LinuxKPI: Use the proper API to determine the ABI of the running process.
ClosedPublic
Actions

Authored by dchagin on Jun 28 2021, 2:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 8, 12:15 AM

	Unknown Object (File)
	Sat, Nov 29, 2:14 AM

	Unknown Object (File)
	Fri, Nov 28, 5:57 AM

	Unknown Object (File)
	Thu, Nov 27, 5:48 AM

	Unknown Object (File)
	Wed, Nov 26, 9:28 AM

	Unknown Object (File)
	Tue, Nov 18, 7:11 PM

	Unknown Object (File)
	Mon, Nov 17, 4:24 AM

	Unknown Object (File)
	Sun, Nov 16, 7:51 AM

Subscribers

Details

Reviewers

• hselasky
markj
kib

Commits

rGba40604902f1: LinuxKPI: Use the proper API to determine the ABI of the running process.
rG945accf502db: LinuxKPI: Use the proper API to determine the ABI of the running process.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40144
Build 37033: arc lint + arc unit

Event Timeline

dchagin created this revision.Jun 28 2021, 2:07 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJun 28 2021, 2:07 PM

dchagin requested review of this revision.Jun 28 2021, 2:07 PM

Harbormaster completed remote builds in B40144: Diff 91440.Jun 28 2021, 2:08 PM

dchagin added reviewers: • hselasky, markj, kib.Jun 28 2021, 2:08 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

markj accepted this revision.Jun 28 2021, 2:14 PM

This revision is now accepted and ready to land.Jun 28 2021, 2:14 PM

kib added inline comments.Jun 28 2021, 2:18 PM

sys/compat/linuxkpi/common/src/linux_compat.c
967	I would also changed this preprocessor check to something along COMPAT_FREEBSD32. I am not sure what exactly this should be. It is not about FreeBSD COMPAT32 exactly, but it is about executing compat32 ioctl handlers.

Current code is under ifdef amd64 . Maybe it should also be activated for aarch64 ?

emaste mentioned this in D30927: LinuxKPI: Put compat code under appropriate condition..Jun 28 2021, 5:52 PM

kib accepted this revision.Jun 28 2021, 5:57 PM

Closed by commit rG945accf502db: LinuxKPI: Use the proper API to determine the ABI of the running process. (authored by dchagin). · Explain WhyJun 29 2021, 5:20 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG945accf502db: LinuxKPI: Use the proper API to determine the ABI of the running process..

dchagin added a commit: rGba40604902f1: LinuxKPI: Use the proper API to determine the ABI of the running process..Jun 17 2022, 7:33 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

3 lines

Diff 91440

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...