Page MenuHomeFreeBSD
Differential D30862

Add OPENMP for riscv64*
ClosedPublic
Actions

Authored by pkubaj on Jun 22 2021, 9:09 AM.
Tags
Referenced Files
F132970508: D30862.diff
Tue, Oct 21, 4:36 PM
Unknown Object (File)
Tue, Oct 14, 8:39 AM
Unknown Object (File)
Mon, Oct 13, 6:48 PM
Unknown Object (File)
Mon, Oct 13, 6:48 PM
Unknown Object (File)
Mon, Oct 13, 6:48 PM
Unknown Object (File)
Mon, Oct 13, 6:48 PM
Unknown Object (File)
Mon, Oct 13, 2:56 PM
Unknown Object (File)
Mon, Oct 13, 5:27 AM
View All Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
mhorne
emaste
dim
Commits
rGaaf56e355699: Enable OPENMP on riscv64* by default.
rGaa033e0b14f2: Enable OPENMP on riscv64* by default.
Summary

Adding OPENMP will fix a bunch of ports that need it.

Test Plan

make buildworld

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Jun 22 2021, 9:09 AM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJun 22 2021, 9:09 AM
pkubaj requested review of this revision.Jun 22 2021, 9:09 AM
mhorne accepted this revision.Jun 24 2021, 7:07 PM
mhorne added reviewers: emaste, dim.

Thanks, this fell off my radar.

I approve the change, but have no idea of the status of OpenMP on RISC-V, and what might be missing/lacking.

This revision is now accepted and ready to land.Jun 24 2021, 7:07 PM
mhorne added inline comments.Jun 24 2021, 7:08 PM
share/mk/src.opts.mk
358

Any reason not to enable for riscv64sf as well?

pkubaj updated this revision to Diff 91344.Jun 25 2021, 1:32 PM
pkubaj retitled this revision from Add OPENMP for riscv64 to Add OPENMP for riscv64*.

Adding riscv64sf.

This revision now requires review to proceed.Jun 25 2021, 1:32 PM
pkubaj marked an inline comment as done.Jun 25 2021, 1:32 PM
mhorne accepted this revision.Jun 25 2021, 1:35 PM
This revision is now accepted and ready to land.Jun 25 2021, 1:35 PM
Closed by commit rGaa033e0b14f2: Enable OPENMP on riscv64* by default. (authored by pkubaj). · Explain WhyJun 25 2021, 2:24 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rGaa033e0b14f2: Enable OPENMP on riscv64* by default..
pkubaj reopened this revision.Dec 19 2021, 9:18 PM

@mhorne
OK to MFC it to stable/13?

Herald added a subscriber: imp. · View Herald TranscriptDec 19 2021, 9:18 PM
mhorne added a comment.Dec 19 2021, 9:57 PM
In D30862#758473, @pkubaj wrote:

@mhorne
OK to MFC it to stable/13?

Sounds fine to me!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 19 2021, 10:43 PM
Closed by commit rGaaf56e355699: Enable OPENMP on riscv64* by default. (authored by pkubaj). · Explain Why
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rGaaf56e355699: Enable OPENMP on riscv64* by default..

Revision Contents
Changeset List

PathSize
share/
mk/
2 lines

Diff 100310

View Options

share/mk/src.opts.mk

Loading...