Page MenuHomeFreeBSD

LinuxKPI: add fault_flag_allow_retry_first
ClosedPublic

Authored by val_packett.cool on Jun 7 2021, 2:26 PM.
Referenced Files
F132481933: D30673.id90521.diff
Fri, Oct 17, 7:13 AM
Unknown Object (File)
Tue, Oct 14, 3:34 PM
Unknown Object (File)
Tue, Oct 14, 2:33 PM
Unknown Object (File)
Tue, Oct 14, 2:33 PM
Unknown Object (File)
Tue, Oct 14, 1:25 PM
Unknown Object (File)
Tue, Oct 14, 5:46 AM
Unknown Object (File)
Tue, Oct 14, 12:53 AM
Unknown Object (File)
Tue, Oct 14, 12:53 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/compat/linuxkpi/common/include/linux/mm.h
96

Parenthesis around (flags) is good macro practice:

I suggest like this:

(((flags) & (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_TRIED)) == FAULT_FLAG_ALLOW_RETRY)

This revision is now accepted and ready to land.Jun 7 2021, 5:23 PM
This revision was automatically updated to reflect the committed changes.