Differential D30673

LinuxKPI: add fault_flag_allow_retry_first
ClosedPublic
Actions

Authored by val_packett.cool on Jun 7 2021, 2:26 PM.

Tags

Referenced Files

	F137866633: D30673.diff
	Wed, Nov 26, 3:15 PM

	Unknown Object (File)
	Tue, Nov 25, 6:12 PM

	Unknown Object (File)
	Tue, Nov 18, 2:41 PM

	Unknown Object (File)
	Tue, Nov 18, 10:56 AM

	Unknown Object (File)
	Mon, Nov 17, 8:45 AM

	Unknown Object (File)
	Fri, Nov 14, 5:30 PM

	Unknown Object (File)
	Tue, Nov 11, 9:34 PM

	Unknown Object (File)
	Sat, Nov 8, 2:40 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

• hselasky
bz
nc

Group Reviewers

Contributor Reviews (src)
linuxkpi

Commits

rG97f3e018fa2f: LinuxKPI: add fault_flag_allow_retry_first
rG07ef7a034965: LinuxKPI: add fault_flag_allow_retry_first
rG597cc550e7b9: LinuxKPI: add fault_flag_allow_retry_first

Summary

This is used in drm 5.7.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jun 7 2021, 2:26 PM

Herald added subscribers: linuxkpi, Contributor Reviews (src), emaste, imp. · View Herald TranscriptJun 7 2021, 2:26 PM

val_packett.cool requested review of this revision.Jun 7 2021, 2:26 PM

Harbormaster completed remote builds in B39768: Diff 90521.Jun 7 2021, 2:26 PM

val_packett.cool added reviewers: Contributor Reviews (src), linuxkpi, • hselasky.Jun 7 2021, 2:26 PM

val_packett.cool added a project: linuxkpi.

• hselasky added inline comments.Jun 7 2021, 2:30 PM

sys/compat/linuxkpi/common/include/linux/mm.h
96	Parenthesis around (flags) is good macro practice: I suggest like this: (((flags) & (FAULT_FLAG_ALLOW_RETRY \| FAULT_FLAG_TRIED)) == FAULT_FLAG_ALLOW_RETRY)

val_packett.cool updated this revision to Diff 90532.Jun 7 2021, 5:15 PM

• hselasky accepted this revision.Jun 7 2021, 5:23 PM

This revision is now accepted and ready to land.Jun 7 2021, 5:23 PM

bz accepted this revision.Jun 7 2021, 5:32 PM

val_packett.cool added a reviewer: nc.Jun 7 2021, 10:32 PM

LGTM.

val_packett.cool mentioned this in D30709: linuxkpi: Define fault_flag_allow_retry_first() macro.Jun 9 2021, 6:25 PM

Closed by commit rG597cc550e7b9: LinuxKPI: add fault_flag_allow_retry_first (authored by val_packett.cool, committed by emaste). · Explain WhyJun 9 2021, 11:13 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG597cc550e7b9: LinuxKPI: add fault_flag_allow_retry_first.

emaste added a commit: rG07ef7a034965: LinuxKPI: add fault_flag_allow_retry_first.Jun 16 2021, 4:50 PM

emaste added a commit: rG97f3e018fa2f: LinuxKPI: add fault_flag_allow_retry_first.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

Diff 90675

sys/compat/linuxkpi/common/include/linux/mm.h

Loading...