Page MenuHomeFreeBSD

Add new port: x11-wm/fvwm3
ClosedPublic

Authored by felix_palmen-it.de on May 7 2021, 12:56 PM.

Details

Summary

update x11-wm/fvwm2 to conflict with this new port on install.
While here, remove a patch that had no effect.

The patch in question did a 'cd' in a make recipe, which won't work, every line of a recipe is executed by its own shell. The resulting package is the same without the patch.

The patching for M4 is gone because fvwm3 doesn't include the module any more.

Things missing: GO support. This new port disables GO for now, because fetching using the go:modules facility doesn't work, I might look for help with it upstream later. So far, it doesn't matter much, the new GO module FvwmPrompt is just a replacement for FvwmCommand and FvwmConsole, which are still available.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Moin moin

Why add a new port instead of updating the existing one?

mfg Tobias

Why add a new port instead of updating the existing one?

  • In fvwm3, the package is called fvwm3 (e.g. in ${LOCALBASE}/share), and a new versioning scheme is introduced, restarting at 1.0.0 (while fvwm2 was always 2.x)
  • Maybe it makes sense to have both versions in parallel for some time, as fvwm3 is still "bleeding edge"
  • At least a rename would be required anyways, as the current port resides in x11-wm/fvwm2 ;)

If you don't mind, I'll make the two minor corrections and commit it. Is that ok?

x11-wm/fvwm3/Makefile
18

I think this should be aligned.

x11-wm/fvwm3/pkg-descr
10

We try to use https where ever possible.

This revision is now accepted and ready to land.May 7 2021, 4:58 PM

Commit message in my D30159 branch (--pretty-fuller):

commit 3b2cb8ece712fdb246c18116c5deae2ff21e7040 (HEAD -> D30159)
Author: Felix Palmen <felix@palmen-it.de>
AuthorDate: Fri May 7 10:01:08 2021 -0700
Commit: Cy Schubert <cy@FreeBSD.org>
CommitDate: Fri May 7 10:01:08 2021 -0700

New port: x11-wm/fvwm3: New FVWM window manager

FVWM is an old window manager based on twm. After a long pause FVWM
development appears to have been restarted. This new FVWM no longer
supports M4 however it does support GO. Unfortunately fetching
go:modules doesn't work and is disabled at the moment. The maintainer
intends to work on this and upstream it when it's finally working.

Submitted by:   Felix Palmen <felix@palmen-it.de>
Reviewed by:    cy
Differential Revision:  https://reviews.freebsd.org/D30159
In D30159#677305, @cy wrote:

If you don't mind, I'll make the two minor corrections and commit it. Is that ok?

Of course, sounds reasonable. I just copied the www url from fvwm2, didn't notice that detail. Thanks a lot!

This revision was automatically updated to reflect the committed changes.