Enable the "other" interrupt on 82574 to receive link status notifications
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211219
Differential D29943
e1000: enable "other" interrupt on 82574 kbowling on Apr 23 2021, 2:03 AM. Authored by Tags None Referenced Files
Subscribers
Details Enable the "other" interrupt on 82574 to receive link status notifications PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211219 @franco_opnsense.org do you have the ability to test this patch on FreeBSD 12+ with the inbox em driver?
Diff Detail
Event TimelineComment Actions @kbowling for us https://cgit.freebsd.org/src/commit/?id=0aa7d3ff9ea resolved the issue back then and has not come back. Is this meant to replace it or to be applied on top? I can test it on the specific hardware, but unsure if this will be inconclusive for the mentioned reason Comment Actions On second thought: maybe I'm mixing up hardware. I'm not sure, but in either case 12.x does seem not exhibit this issue judging from the complete lack of user reports. Comment Actions I have trouble understanding why that diff is sufficient. We end up setting a bit for "other" in EIAC but not IMS, so as far as I understand, the interrupt is still not enabled. Before rS286831, we set "other" in both EAIC and IMS, but that revision changed em_enable_intr() for some unexplained reason that looks unrelated to the rest of the diff. Maybe it's some debug patch that snuck in. https://cgit.freebsd.org/src/commit/?id=0aa7d3ff9ea reverts only part of that hunk. The intel-em-kmod driver sets "other" in both registers, as the in-tree FreeBSD driver did originally. The diff in this review will, I believe, bring us back to the pre-rS286831 behaviour for the 82574, so it looks ok to me, but it's hard to judge whether this is necessary given an apparent lack of problem reports.
Comment Actions Franco, yes I think if you carefully read the code and the comments from erj (in the PR) and markj here you will come agreement. I suspect some of your users are using the intel-em-kmod when they encounter issues like this. I would be delighted if we can get them back to the FreeBSD driver, especially with small fixes such as this,.
Comment Actions I think the change is ok, I would just suggest simplifying em_msix_link() per my comment there. I tested the diff with an I210 (igb) and didn't notice any obvious regressions there.
|