Differential D29399

LinuxKPI: add net_ratelimit()
ClosedPublic
Actions

Authored by bz on Mar 23 2021, 5:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 25, 5:05 PM

	Unknown Object (File)
	Mon, Aug 24, 6:24 PM

	Unknown Object (File)
	Sun, Aug 16, 11:04 PM

	Unknown Object (File)
	Sat, Aug 15, 9:03 PM

	Unknown Object (File)
	Sat, Aug 15, 6:03 PM

	Unknown Object (File)
	Fri, Aug 14, 10:35 AM

	Unknown Object (File)
	Mon, Aug 10, 9:54 PM

	Unknown Object (File)
	Sun, Aug 9, 3:08 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG7e34088b7800: LinuxKPI: add net_ratelimit()
rG834afdc9242d: LinuxKPI: add net_ratelimit()
rGbc042266b2bf: LinuxKPI: add net_ratelimit()

Summary

Add a net_ratelimit() compat implementation based on ppsratecheck().
Add a sysctl to allow tuning of the number of messages.

Sponsored-by: The FreeBSD Foundation
MFC-after: 2 weeks
Reviewed-by: ...
Differential Revision:

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Mar 23 2021, 5:13 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMar 23 2021, 5:13 PM

bz requested review of this revision.Mar 23 2021, 5:13 PM

Harbormaster completed remote builds in B38024: Diff 86212.Mar 23 2021, 5:13 PM

• hselasky added a subscriber: • hselasky.Mar 23 2021, 7:43 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/net.h
79	Please don't declare static variables in header files. Make them global and possibly into SYSCTLs.

Migrate function and static variables into the implementation file
and add a SYSCTl to allow tuning the number of messages as suggested
by @hselasky.

Harbormaster completed remote builds in B38054: Diff 86266.Mar 24 2021, 7:05 PM

bz edited the summary of this revision. (Show Details)Mar 24 2021, 7:05 PM

bz marked an inline comment as done.

emaste added inline comments.Mar 24 2021, 7:09 PM

sys/compat/linuxkpi/common/src/linux_compat.c
105	Does Linux default to 99 for its equivalent, or is this just a convenient number?

bz marked an inline comment as done.Mar 24 2021, 7:19 PM

bz added inline comments.

sys/compat/linuxkpi/common/src/linux_compat.c
105	I cannot tell you what Linux defaults to as that would require me reading (likely) GPL code. It is a convenience number as I figure I can survive with 99 log messages / s on a serial console these days if worse comes to worse.

Looks good.

This revision is now accepted and ready to land.Mar 24 2021, 7:32 PM

• hselasky added inline comments.Mar 24 2021, 7:33 PM

sys/compat/linuxkpi/common/src/linux_compat.c
106	Use CTLFLAG_RWTUN .

emaste added inline comments.Mar 24 2021, 8:09 PM

sys/compat/linuxkpi/common/src/linux_compat.c
105	Ok - mainly was just curious, but either way it doesn't matter much, we can change the default based on feedback if it proves necessary.

bz marked an inline comment as done.Mar 24 2021, 9:31 PM

bz added inline comments.

sys/compat/linuxkpi/common/src/linux_compat.c
106	Is there a specific reason we need this to be a tunable so it's available before /etc/rc.d/sysctl runs?

bz marked an inline comment as done.Mar 26 2021, 12:16 PM

Closed by commit rGbc042266b2bf: LinuxKPI: add net_ratelimit() (authored by bz). · Explain WhyMar 26 2021, 12:16 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGbc042266b2bf: LinuxKPI: add net_ratelimit().

bz added a commit: rG834afdc9242d: LinuxKPI: add net_ratelimit().Jul 18 2021, 12:36 AM

• hselasky added a commit: rG7e34088b7800: LinuxKPI: add net_ratelimit().Nov 12 2021, 2:45 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

10 lines

src/

15 lines

Diff 86334

sys/compat/linuxkpi/common/include/linux/net.h

Loading...

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...