Ensure cwnd doesn't shrink to zero with PRR
ClosedPublic
Actions

Authored by rscheff on Feb 18 2021, 7:59 PM.

Details

Reviewers

Group Reviewers

Commits

rGb8ffda0a37e1: tcp: various improvements and fixes to PRR
rGc3aa4ba5dfc0: Ensure cwnd doesn't shrink to zero with PRR
rG853fd7a2e398: Ensure cwnd doesn't shrink to zero with PRR

Summary

Under some circumstances, PRR may end up with a fully
collapsed cwnd when finalizing the loss recovery.

Also, in case PRR is working against an empty scoreboard,
a possibilty for an integer overflow exists. Performing
signed arithmetics to address a possible sudden jump of cwnd.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Feb 18 2021, 7:59 PM

Herald added a reviewer: transport. · View Herald TranscriptFeb 18 2021, 7:59 PM

Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Feb 18 2021, 7:59 PM

Harbormaster completed remote builds in B37166: Diff 84224.Feb 18 2021, 7:59 PM

kbowling accepted this revision.Feb 19 2021, 1:40 AM

This revision is now accepted and ready to land.Feb 19 2021, 1:40 AM

Closed by commit rG853fd7a2e398: Ensure cwnd doesn't shrink to zero with PRR (authored by rscheff). · Explain WhyFeb 19 2021, 1:41 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG853fd7a2e398: Ensure cwnd doesn't shrink to zero with PRR.

rscheff added a commit: rGc3aa4ba5dfc0: Ensure cwnd doesn't shrink to zero with PRR.Feb 26 2021, 10:17 AM

rscheff added a commit: rGb8ffda0a37e1: tcp: various improvements and fixes to PRR.Mar 4 2021, 12:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

4 lines

Diff 84261

View Options

Ensure cwnd doesn't shrink to zero with PRRClosedPublicActions