Page MenuHomeFreeBSD
Differential D28158

opencrypto: Embed the driver softc in the session structure
ClosedPublic
Actions

Authored by markj on Jan 14 2021, 4:35 PM.
Tags
None
Referenced Files
F153759263: D28158.diff
Thu, Apr 23, 12:06 PM
F153693354: D28158.diff
Wed, Apr 22, 11:44 PM
Unknown Object (File)
Sat, Apr 18, 4:45 PM
Unknown Object (File)
Sat, Apr 11, 11:36 PM
Unknown Object (File)
Wed, Apr 8, 2:10 PM
Unknown Object (File)
Wed, Apr 8, 8:36 AM
Unknown Object (File)
Tue, Apr 7, 4:16 PM
Unknown Object (File)
Mon, Apr 6, 7:55 AM
View All Files
Subscribers
imp

Details

Reviewers
jmg
jhb
cem
Commits
rGd1816248899a: opencrypto: Embed the driver softc in the session structure
Summary

Get rid of the crypto session UMA zone. I do not think session
allocations are frequent or performance-critical enough to warrant a
dedicated zone.

Store the driver softc below the fields owned by opencrypto. This is
a bit simpler and saves a pointer dereference when fetching the driver
softc when processing a request.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jan 14 2021, 4:35 PM
Herald added a reviewer: jmg. · View Herald TranscriptJan 14 2021, 4:35 PM
Herald added a subscriber: imp. · View Herald Transcript
markj requested review of this revision.Jan 14 2021, 4:35 PM
Harbormaster completed remote builds in B36201: Diff 82269.Jan 14 2021, 4:35 PM
markj added a parent revision: D28157: aesni: Ensure that key schedules are aligned.Jan 14 2021, 4:35 PM
markj added a reviewer: jhb.Jan 14 2021, 4:35 PM
markj added a child revision: D28159: opencrypto: Fix assignment of crypto completions to worker threads.Jan 14 2021, 4:36 PM
markj added a reviewer: cem.Jan 14 2021, 4:36 PM
cem accepted this revision.Jan 14 2021, 5:08 PM

Sure, seems fine to me.

This revision is now accepted and ready to land.Jan 14 2021, 5:08 PM
jhb accepted this revision.Jan 19 2021, 6:56 PM
Closed by commit rGd1816248899a: opencrypto: Embed the driver softc in the session structure (authored by markj). · Explain WhyJan 20 2021, 1:36 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGd1816248899a: opencrypto: Embed the driver softc in the session structure.

Revision Contents
Changeset List

PathSize
sys/
opencrypto/
17 lines

Diff 82596

View Options

sys/opencrypto/crypto.c

Loading...