Page MenuHomeFreeBSD
Differential D28158

opencrypto: Embed the driver softc in the session structure
ClosedPublic
Actions

Authored by markj on Jan 14 2021, 4:35 PM.
Tags
None
Referenced Files
F141290323: D28158.id82596.diff
Sat, Jan 3, 4:02 PM
F141290319: D28158.id82596.diff
Sat, Jan 3, 4:02 PM
F141290314: D28158.id82596.diff
Sat, Jan 3, 4:02 PM
Unknown Object (File)
Thu, Jan 1, 7:28 AM
Unknown Object (File)
Fri, Dec 12, 11:26 PM
Unknown Object (File)
Dec 3 2025, 10:31 PM
Unknown Object (File)
Nov 27 2025, 12:02 AM
Unknown Object (File)
Nov 17 2025, 8:05 AM
View All Files
Subscribers
imp

Details

Reviewers
jmg
jhb
cem
Commits
rGd1816248899a: opencrypto: Embed the driver softc in the session structure
Summary

Get rid of the crypto session UMA zone. I do not think session
allocations are frequent or performance-critical enough to warrant a
dedicated zone.

Store the driver softc below the fields owned by opencrypto. This is
a bit simpler and saves a pointer dereference when fetching the driver
softc when processing a request.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36201
Build 33090: arc lint + arc unit

Event Timeline

markj created this revision.Jan 14 2021, 4:35 PM
Herald added a reviewer: jmg. · View Herald TranscriptJan 14 2021, 4:35 PM
Herald added a subscriber: imp. · View Herald Transcript
markj requested review of this revision.Jan 14 2021, 4:35 PM
Harbormaster completed remote builds in B36201: Diff 82269.Jan 14 2021, 4:35 PM
markj added a parent revision: D28157: aesni: Ensure that key schedules are aligned.Jan 14 2021, 4:35 PM
markj added a reviewer: jhb.Jan 14 2021, 4:35 PM
markj added a child revision: D28159: opencrypto: Fix assignment of crypto completions to worker threads.Jan 14 2021, 4:36 PM
markj added a reviewer: cem.Jan 14 2021, 4:36 PM
cem accepted this revision.Jan 14 2021, 5:08 PM

Sure, seems fine to me.

This revision is now accepted and ready to land.Jan 14 2021, 5:08 PM
jhb accepted this revision.Jan 19 2021, 6:56 PM
Closed by commit rGd1816248899a: opencrypto: Embed the driver softc in the session structure (authored by markj). · Explain WhyJan 20 2021, 1:36 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGd1816248899a: opencrypto: Embed the driver softc in the session structure.

Revision Contents
Changeset List

PathSize
sys/
opencrypto/
17 lines

Diff 82269

View Options

sys/opencrypto/crypto.c

Loading...