Differential D28148

Remove unnecessary locks in function timerfd_close
ClosedPublic
Actions

Authored by ankohuu_outlook.com on Jan 14 2021, 4:52 AM.

Tags

None

Subscribers

Contributor Reviews (base)

Details

Reviewers

dchagin
delphij

Commits

R10:14c40d2c292d: linux: remove locks around callout_drain in timerfd_close()

Summary

The Lock around timerfd_drain is unnecessary and may cause
deadloop when close timerfd during timer execution

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ankohuu_outlook.com created this revision.Jan 14 2021, 4:52 AM

Herald added subscribers: Contributor Reviews (base), imp. · View Herald TranscriptJan 14 2021, 4:52 AM

ankohuu_outlook.com requested review of this revision.Jan 14 2021, 4:52 AM

Harbormaster completed remote builds in B36190: Diff 82247.Jan 14 2021, 4:52 AM

lwhsu added a reviewer: dchagin.Jan 14 2021, 6:11 AM

ygy added a subscriber: ygy.Jan 14 2021, 6:27 AM

LGTM

This revision is now accepted and ready to land.Jan 14 2021, 8:22 AM

ankohuu_outlook.com mentioned this in D28231: linux_timerfd_settime set expirations count to zero.Tue, Feb 2, 3:11 PM

Closed by commit R10:14c40d2c292d: linux: remove locks around callout_drain in timerfd_close() (authored by ankohuu_outlook.com, committed by trasz). · Explain WhyWed, Feb 3, 7:48 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: R10:14c40d2c292d: linux: remove locks around callout_drain in timerfd_close().

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

2 lines

Diff 83324

sys/compat/linux/linux_event.c

Loading...