Page MenuHomeFreeBSD

Restructure the crypto(7) manpage and add authentication algorithms.
ClosedPublic

Authored by jhb on Dec 30 2020, 12:49 AM.

Details

Summary

Add separate sections for authentication algorithms, block ciphers,
stream ciphers, and AEAD algorithms. Describe properties commmon to
algorithms in each section to avoid duplication.

Use flat tables to list algorithm properties rather than nested
tables.

List implemented authentication algorithms.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Dec 30 2020, 12:49 AM
debdrup added inline comments.
share/man/man7/crypto.7
30

Since @bcr hasn't been here yet, I get to remind someone else to remember to bump .Dd ;)

171

s/manpage/man-page/, according to igor

0mp added inline comments.
share/man/man7/crypto.7
166

Missing comma.

171

Shouldn't it be just /manual page/?

share/man/man7/crypto.7
171

I just checked intro(4), devfs(5), and a couple other manual pages, and that is indeed the phrasing, so yes. :)

jhb marked 4 inline comments as done.
  • Add comma, correct pre-existing "manpage".
share/man/man7/crypto.7
30

Since @bcr hasn't been here yet, I get to remind someone else to remember to bump .Dd ;)

I don't bother bumping until the commit date since it is always stale during review otherwise.

166

Missing comma.

Is it also better to spell out "for example" explicitly?

gbe added a subscriber: gbe.

LGTM, since all previous comments are addressed.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 21 2021, 12:41 AM
This revision was automatically updated to reflect the committed changes.