Add atf-lua, a lua analog to atf-sh(1) and atf-sh(3)

[kevans]

Summary

This allows us to write tests in lua and hook them up to the existing kyua infrastructure. The atf-lua(3) library attempts to resemble atf-sh(3) to some extent, but takes advantage of some lua features to improve the test-writing experience.

[kevans]

Fix the build against my lua54 branch -- LUA_ERRGCMM has been removed because they will not be a thing anymore.

[lwhsu]

Would it be better to go to https://github.com/freebsd/atf first then merge to contrib?

[kevans]

In D26928#600882, @lwhsu wrote:

Would it be better to go to https://github.com/freebsd/atf first then merge to contrib?

I wasn't sure which offers a better review interface, but FreeBSD/atf is indeed the intended first stop.

[kevans]

I've pushed an updated version @ https://github.com/freebsd/atf/pull/9 that sorts out some header and lua compatibility issues, along with adding the build glue for standalone atf.

[arichardson]

Thanks for working on this! Hopefully this means fewer atf-sh tests in the future. Tests written in shell are unnecessarily slow and massively increase CI time on emulated platforms such as QEMU (and even more so on CHERI QEMU since we have to emulate tagged memory).

contrib/atf/atf-lua/integration_test.sh

1

This copyright notice seems wrong?

Also how much effort would it be to rewrite these tests in atf-c/atf-c++. I spent a lot of time trying to speed up CI on CheriBSD and the biggest overhead seems to be all the processes spawned by tests written in shell instead of a real programming language.

[kevans]

contrib/atf/atf-lua/integration_test.sh

1

It was mostly verbatim stolen from the atf-sh integration_test with a couple bits filed off and a couple bits added, so I just left the copyright intact.

It should be nearly trivial to rewrite these atf-sh tests in atf-c or atf-c++ (I'm inclined to go atf-c personally), they're mostly exec()ing the test helper and inspecting some combination of stdout/stderr/exit status.

[gbe]

Ok from the man page perspective. Did you checked the man pages via igor and mandoc -Tlint?

contrib/atf/atf-lua/atf-lua.1

4

2020

contrib/atf/atf-lua/atf-lua.3

4

2020

[kevans]

Sorry, I'm going to actually abandon this soon-ish... instead of hacking it into atf, I've added support for luaunit and imported it locally.

[rpokala]

contrib/atf/atf-lua/atf-lua.1

5

Nuke the "All rights reserved." from all the files.