Page MenuHomeFreeBSD

jail(3lua): Add some basic tests
Needs ReviewPublic

Authored by kevans on Oct 24 2020, 4:03 PM.
Tags
None
Referenced Files
F176254707: D26932.diff
Sat, Oct 17, 9:32 AM
F176239460: D26932.diff
Sat, Oct 17, 5:57 AM
Unknown Object (File)
Mon, Oct 12, 7:55 AM
Unknown Object (File)
Sun, Oct 11, 3:07 AM
Unknown Object (File)
Sat, Oct 10, 5:10 PM
Unknown Object (File)
Fri, Oct 9, 4:08 PM
Unknown Object (File)
Thu, Oct 1, 9:32 PM
Unknown Object (File)
Thu, Oct 1, 1:57 AM

Details

Reviewers
rmoeller

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 34362

Event Timeline

Curious, why are libifconfig bindings in the stack?

In D26932#601288, @freqlabs wrote:

Curious, why are libifconfig bindings in the stack?

I don't know, that's a bit unusual... it doesn't look like I accidentally slapped any dependency on there (transitively or otherwise), so I'm not really sure since the only connection is that that's also dependent upon the (now-committed) libjail bits.

In D26932#601288, @freqlabs wrote:

Curious, why are libifconfig bindings in the stack?

I don't know, that's a bit unusual... it doesn't look like I accidentally slapped any dependency on there (transitively or otherwise), so I'm not really sure since the only connection is that that's also dependent upon the (now-committed) libjail bits.

That's probably it then. Ok. I was looking at what I'd need to get through in the stack before I'd be able to get to here and that one caught me by surprise. :)

I'll look through the rest of the review later.

etc/mtree/BSD.tests.dist
296

This needs to be below, or the indentation is off here.

I was reading the diff stack wrong. This doesn't depend on flua-libifconfig after all, it's just displayed in the stack because it has a common ancestor: flua-libjail.