Page MenuHomeFreeBSD

Make sure the multicast release tasks are properly drained when destroying VNET and IFNET
Needs ReviewPublic

Authored by hselasky on Tue, May 19, 10:33 AM.

Details

Reviewers
bz
kib
Summary

Make sure the multicast release tasks are properly drained when destroying VNET and IFNET.
Else the inm release tasks may panic accessing a freed VNET and IFNET.

MFC after: 1 week
Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 31175

Event Timeline

hselasky created this revision.Tue, May 19, 10:33 AM
hselasky requested review of this revision.Tue, May 19, 10:33 AM
kib added inline comments.Tue, May 19, 3:34 PM
sys/netinet/in_mcast.c
254

Is this ordered 'enough' to ensure that the drain happens after all other stuff ?

sys/netinet6/in6_mcast.c
523

This is an unrelated fix, right ?

hselasky added inline comments.Wed, May 20, 11:54 AM
sys/netinet/in_mcast.c
254

Testing is ongoing. From what I can see this is good enough.

sys/netinet6/in6_mcast.c
523

Yes, minor nit while at it. SYSINITs should take a pointer argument.