veloader use vectx API for kernel and modules

[sjg]

Summary

The vectx API, computes the hash for verifying a file as it is read.
This avoids the overhead of reading files twice - once to verify, then
again to load.

For doing an install via loader, avoiding the need to rewind
large files is critical.

This api is only used for modules, kernel and mdimage as these are the
biggest files read by the loader.
The reduction in boot time depends on how expensive the I/O is
on any given platform. On a fast VM we see 6% improvement.

For install via loader the first file to be verified is likely to be the
kernel, so some of the prep work (finding manifest etc) done by
verify_file() needs to be factored so it can be reused for
vectx_open().

Since vectx API is only used for files which must be verified
(VE_MUST) we panic if we get an incorrect hash.

[sjg]

update test app

[sjg]

Add readin.h to define READIN_HANDLE_T

[sjg]

Add readin.h to define READIN_HANDLE_T

[imp]

This looks decent, imho, but I wonder why you're using #defines instead of more language appropriate features.

stand/common/readin.h

34–41

Why are the types #defines?
Why are the vectx_read and vectx_lseek not function pointers?

[sjg]

stand/common/readin.h

34–41

Good question.
typedefs should be possible.
function pointers need to be stored somewhere...

[sjg]

Use typedef for readin_handle_t

[imp]

Seems reasonable. This could be a lot more intrusive