bhyve: use stream_read() to read 12 bytes of RFB client version
ClosedPublic
Actions

Authored by khng on Feb 9 2020, 3:51 PM.

Details

Reviewers

grehan
jhb

Group Reviewers

bhyve

Commits

rS358394: Use stream_read() to read all 12 bytes of the RFB client version.

Summary

The use of read() to read RFB client version before this change is inappropriate as it is not guaranteed to have exactly 12 bytes in the receive buffer.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng created this revision.Feb 9 2020, 3:51 PM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptFeb 9 2020, 3:51 PM

Harbormaster completed remote builds in B29254: Diff 68010.Feb 9 2020, 3:51 PM

afedorov added a subscriber: afedorov.Feb 9 2020, 8:01 PM

grehan accepted this revision.Feb 10 2020, 2:22 AM

grehan added a subscriber: grehan.

grehan added inline comments.

usr.sbin/bhyve/rfb.c
773 ↗	(On Diff #68010)	Put in #define VERSION_LENGTH 12 at the top, use that instead of 12, and this will be good to go.

This revision is now accepted and ready to land.Feb 10 2020, 2:22 AM

lwhsu added a subscriber: lwhsu.Feb 10 2020, 8:07 AM

bhyve: use stream_read() to read 12 bytes of RFB client version

This revision now requires review to proceed.Feb 10 2020, 8:39 AM

Harbormaster completed remote builds in B29262: Diff 68048.Feb 10 2020, 8:39 AM

khng marked an inline comment as done.Feb 10 2020, 8:40 AM

Updating D23591: bhyve: use stream_read() to read 12 bytes of RFB client version

Harbormaster completed remote builds in B29263: Diff 68049.Feb 10 2020, 8:42 AM

khng added inline comments.Feb 12 2020, 8:53 AM

usr.sbin/bhyve/rfb.c
773 ↗	(On Diff #68010)	Changed as suggested.

jhb accepted this revision.Feb 13 2020, 5:07 PM

This revision is now accepted and ready to land.Feb 13 2020, 5:07 PM

Closed by commit rS358394: Use stream_read() to read all 12 bytes of the RFB client version. (authored by jhb). · Explain WhyFeb 27 2020, 4:51 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS358394: Use stream_read() to read all 12 bytes of the RFB client version..

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2020, 4:51 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

rfb.c

3 lines

Diff 68889

View Options

bhyve: use stream_read() to read 12 bytes of RFB client versionClosedPublicActions