Page MenuHomeFreeBSD
Differential D22657

bhyve: add wrapper for debug printf statements
ClosedPublic
Actions

Authored by vmaffione on Dec 3 2019, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 3:31 PM
Unknown Object (File)
Wed, May 8, 3:31 PM
Unknown Object (File)
Wed, May 8, 3:26 PM
Unknown Object (File)
Wed, May 8, 3:26 PM
Unknown Object (File)
Wed, May 8, 3:26 PM
Unknown Object (File)
Fri, May 3, 9:44 PM
Unknown Object (File)
Thu, May 2, 12:16 AM
Unknown Object (File)
Thu, May 2, 12:16 AM
View All 50 Files
Subscribers
afedorov
bcran
grehan
imp
markj

Details

Reviewers
jhb
• ian
rgrimes
grehan
Group Reviewers
bhyve
Commits
rS358184: MFC r356523
rS356523: bhyve: add wrapper for debug printf statements
Summary

A wrapper to use CR/CRLF terminators depending on the situation.
Try to use the wrapper everywhere.
For now we leave the custom DPRINTF/WPRINTF defined by device models.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vmaffione created this revision.Dec 3 2019, 10:26 PM
Herald added a reviewer: bhyve. · View Herald TranscriptDec 3 2019, 10:26 PM
Herald added a subscriber: bcran. · View Herald Transcript
rgrimes added a comment.Dec 5 2019, 6:54 AM

Can you first revert the wrong change, which cleans this up by not doing the deletes of \n\r that was added by that diff.

usr.sbin/bhyve/debug.h
5 ↗(On Diff #65182)

Please remove the All rights reserved, it is not needed or desired.

vmaffione updated this revision to Diff 65330.Dec 6 2019, 9:27 PM

Removed "all rights reserved" line.
Fix multi-line debug logs in pci_xhci.c, splitting them into multiple PRINTLN() statements.

vmaffione marked an inline comment as done.Dec 6 2019, 9:27 PM
vmaffione added a comment.Dec 23 2019, 2:34 PM

Thoughts about this change?

vmaffione added a comment.Jan 7 2020, 9:29 PM

Comments?

grehan accepted this revision.Jan 7 2020, 9:53 PM
grehan added a subscriber: grehan.

A worthwhile change.

usr.sbin/bhyve/debug.h
15 ↗(On Diff #65330)

You might want to put "THE AUTHOR" here instead of NETAPP :)

This revision is now accepted and ready to land.Jan 7 2020, 9:53 PM
vmaffione updated this revision to Diff 66465.Jan 7 2020, 10:29 PM
vmaffione marked an inline comment as done.
  • Aligned to current head.
  • Fixed header in debug.h
This revision now requires review to proceed.Jan 7 2020, 10:29 PM
vmaffione added inline comments.Jan 7 2020, 10:30 PM
usr.sbin/bhyve/debug.h
15 ↗(On Diff #65330)

Very good point, thanks :)

jhb accepted this revision.Jan 7 2020, 10:39 PM
This revision is now accepted and ready to land.Jan 7 2020, 10:39 PM
Closed by commit rS356523: bhyve: add wrapper for debug printf statements (authored by vmaffione). · Explain WhyJan 8 2020, 10:55 PM
This revision was automatically updated to reflect the committed changes.
vmaffione added a commit: rS356523: bhyve: add wrapper for debug printf statements.
Herald added a subscriber: imp. · View Herald TranscriptJan 8 2020, 10:55 PM
vmaffione added a commit: rS358184: MFC r356523.Feb 20 2020, 9:49 PM
rew mentioned this in D40109: bhyve: [snapshot] Use pci_next() to save/restore pci devices.May 16 2023, 4:27 PM

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
28 lines
2 lines
9 lines
15 lines
2 lines
47 lines
44 lines
11 lines
23 lines
3 lines
44 lines
157 lines
7 lines
23 lines
2 lines
68 lines
13 lines
235 lines
5 lines
13 lines
11 lines
11 lines
11 lines
23 lines
270 lines
11 lines
9 lines
17 lines
3 lines
3 lines
2 lines
71 lines
59 lines
3 lines

Diff 66522

View Options

head/usr.sbin/bhyve/audio.c

Loading...
View Options

head/usr.sbin/bhyve/bhyverun.c

Loading...
View Options

head/usr.sbin/bhyve/block_if.c

Loading...
View Options

head/usr.sbin/bhyve/bootrom.c

Loading...
View Options

head/usr.sbin/bhyve/consport.c

Loading...
View Options

head/usr.sbin/bhyve/debug.h

Loading...
View Options

head/usr.sbin/bhyve/hda_codec.c

Loading...
View Options

head/usr.sbin/bhyve/mptbl.c

Loading...
View Options

head/usr.sbin/bhyve/net_backends.c

Loading...
View Options

head/usr.sbin/bhyve/net_utils.c

Loading...
View Options

head/usr.sbin/bhyve/pci_ahci.c

Loading...
View Options

head/usr.sbin/bhyve/pci_e82545.c

Loading...
View Options

head/usr.sbin/bhyve/pci_emul.c

Loading...
View Options

head/usr.sbin/bhyve/pci_fbuf.c

Loading...
View Options

head/usr.sbin/bhyve/pci_hda.h

Loading...
View Options

head/usr.sbin/bhyve/pci_hda.c

Loading...
View Options

head/usr.sbin/bhyve/pci_lpc.c

Loading...
View Options

head/usr.sbin/bhyve/pci_nvme.c

Loading...
View Options

head/usr.sbin/bhyve/pci_uart.c

Loading...
View Options

head/usr.sbin/bhyve/pci_virtio_block.c

Loading...
View Options

head/usr.sbin/bhyve/pci_virtio_console.c

Loading...
View Options

head/usr.sbin/bhyve/pci_virtio_net.c

Loading...
View Options

head/usr.sbin/bhyve/pci_virtio_rnd.c

Loading...
View Options

head/usr.sbin/bhyve/pci_virtio_scsi.c

Loading...
View Options

head/usr.sbin/bhyve/pci_xhci.c

Loading...
View Options

head/usr.sbin/bhyve/ps2kbd.c

Loading...
View Options

head/usr.sbin/bhyve/ps2mouse.c

Loading...
View Options

head/usr.sbin/bhyve/rfb.c

Loading...
View Options

head/usr.sbin/bhyve/smbiostbl.c

Loading...
View Options

head/usr.sbin/bhyve/task_switch.c

Loading...
View Options

head/usr.sbin/bhyve/uart_emul.c

Loading...
View Options

head/usr.sbin/bhyve/usb_mouse.c

Loading...
View Options

head/usr.sbin/bhyve/virtio.c

Loading...
View Options

head/usr.sbin/bhyve/xmsr.c

Loading...