Page MenuHomeFreeBSD
Differential D22302

amd64: move gdt into pcpu
ClosedPublic
Actions

Authored by kib on Nov 10 2019, 10:56 AM.
Tags
None
Referenced Files
F82263618: D22302.id64233.diff
Sat, Apr 27, 2:36 AM
F82263578: D22302.id64235.diff
Sat, Apr 27, 2:35 AM
F82263576: D22302.id.diff
Sat, Apr 27, 2:35 AM
F82263477: D22302.id64144.diff
Sat, Apr 27, 2:34 AM
F82256279: D22302.diff
Sat, Apr 27, 12:58 AM
Unknown Object (File)
Dec 20 2023, 1:08 AM
Unknown Object (File)
Dec 12 2023, 2:36 PM
Unknown Object (File)
Nov 25 2023, 12:09 AM
View All 29 Files
Subscribers
bcran
imp
pho
rgrimes

Details

Reviewers
alc
jhb
markj
gnn
Group Reviewers
bhyve
Commits
rS354646: amd64: move GDT into PCPU area.
rS354644: amd64: assert that size of the software prototype table for gdt is equal

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Nov 10 2019, 10:56 AM
Herald added a reviewer: gnn. · View Herald TranscriptNov 10 2019, 10:56 AM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
Harbormaster completed remote builds in B27427: Diff 64144.Nov 10 2019, 10:56 AM
markj added inline comments.Nov 10 2019, 3:37 PM
sys/amd64/amd64/pmap.c
1782 ↗(On Diff #64144)

Why does GSBASE need to be set again?

kib added inline comments.Nov 10 2019, 4:00 PM
sys/amd64/amd64/pmap.c
1782 ↗(On Diff #64144)

Because lgdt() != LGDT, it reloads %gs. I could have used bare_lgdt(), but think that we better reload there segment cache as well, actually.

markj accepted this revision as: markj.Nov 10 2019, 7:10 PM
pho added a comment.Nov 11 2019, 7:41 AM

Just an update: I'm at test number 534 out of 677 with an uptime of 20 hours (tests are sorted by increasing run time).
No problems so far.

jhb accepted this revision.Nov 11 2019, 4:28 PM

I wish one could use PCPU_GET(gdt) instead of *PCPU_PTR(gdt) to look more readable, but I understand why we can't do that.

pho added a comment.Nov 12 2019, 12:28 PM

I ran the full stress2 test using 64144. No problems seen.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 12 2019, 3:47 PM
Closed by commit rS354644: amd64: assert that size of the software prototype table for gdt is equal (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS354644: amd64: assert that size of the software prototype table for gdt is equal.
kib reopened this revision.Nov 12 2019, 3:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 12 2019, 3:51 PM
Closed by commit rS354646: amd64: move GDT into PCPU area. (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS354646: amd64: move GDT into PCPU area..

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
10 lines
24 lines
16 lines
5 lines
include/
4 lines
1 line
vmm/
2 lines
cddl/
contrib/
opensolaris/
uts/
intel/
dtrace/
2 lines

Diff 64235

View Options

head/sys/amd64/amd64/machdep.c

Loading...
View Options

head/sys/amd64/amd64/mp_machdep.c

Loading...
View Options

head/sys/amd64/amd64/pmap.c

Loading...
View Options

head/sys/amd64/amd64/trap.c

Loading...
View Options

head/sys/amd64/include/pcpu.h

Loading...
View Options

head/sys/amd64/include/segments.h

Loading...
View Options

head/sys/amd64/vmm/vmm_host.h

Loading...
View Options

head/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c

Loading...