Emulated S3 with s0ix (not currently working)
Needs ReviewPublic
Actions

Authored by bwidawsk on Oct 23 2018, 10:20 PM.

Details

Reviewers

Summary

These were developed on github:
https://github.com/bwidawsk/freebsd/tree/s0ix

S0ix is the name of Intel's implementation of Low Power Idle states as described
in ACPI spec via LPIT, and SPMC. It can be thought of as a hardware managed
suspend state whereby all software needs to do is sufficiently idle the system,
and hardware will go into the lower power state until woken by a specified set
of events.

Newer laptops with Intel CPUs prefer a sleep state known as s0ix (where x can be
1, 2, or 3). s0ix entry and benefits are explained in the patches found on
github.

Test Plan

Test suspend to idle on a machine supporting s0ix. Use residency
counters to determine if successful.

Diff Detail

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 20375
Build 19816: arc lint + arc unit

Event Timeline

bwidawsk created this revision.Oct 23 2018, 10:20 PM

Harbormaster completed remote builds in B20375: Diff 49532.Oct 23 2018, 10:20 PM

The hunks for the idle suspend stuff were some WIP that I hadn't finished. They can be ignored.

bwidawsk added a parent revision: D17675: Suspend to idle support.Oct 23 2018, 10:28 PM

bwidawsk added a parent revision: D16635: Summary: acpi: fix acpi_ec_probe to only check EC devices.

Small fix for systems which don't have a pm device

Harbormaster completed remote builds in B20436: Diff 49637.Oct 25 2018, 11:38 PM

scottph added a subscriber: scottph.Nov 29 2018, 7:49 PM

lwhsu added a subscriber: lwhsu.Dec 4 2018, 5:03 PM

greg_unrelenting.technology added a subscriber: greg_unrelenting.technology.Dec 25 2018, 9:00 PM

scottl added a subscriber: scottl.Jun 12 2019, 2:49 PM

Revision Contents
Changeset List

		Path
M		sys/conf/files.amd64 (2 lines)
M		sys/dev/acpica/acpi.c (132 lines)
A	M	sys/dev/acpica/acpi_lpit.c (199 lines)
A	M	sys/dev/acpica/acpi_spmc.c (417 lines)
M		sys/dev/acpica/acpivar.h (5 lines)
M		sys/kern/device_if.m (64 lines)
M		sys/kern/subr_bus.c (12 lines)
M		sys/sys/bus.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49532	6d58ced		Oct 23 2018, 10:20 PM	★	★
Diff 2	49637	78b284c	Small fix for systems which don't have a pm device	Oct 25 2018, 11:38 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
22b912716dc7	7439b38c2efe	e9176f46973e	Ben Widawsky	Turn on emulated S3 with s0ix (Show More…)	Sep 10 2018, 5:02 PM
e9176f46973e	53794faf6411	e446a1300f31	Ben Widawsky	acpi: Notify when lp idle might be available (Show More…)	Aug 7 2018, 5:09 PM
e446a1300f31	1310808bf6e3	19769d018363	Ben Widawsky	acpi/spmc: Implement post suspend and resume	Oct 11 2018, 10:00 PM
19769d018363	294cb7e9602d	1709d679b0f8	Ben Widawsky	device: Add post suspend/resume (Show More…)	Aug 10 2018, 10:40 PM
1709d679b0f8	0e331a63b304	af2053c9f849	Ben Widawsky	acpi: Convert sleep states to bits (Show More…)	Oct 16 2018, 5:13 AM
af2053c9f849	46157326abdf	d34ca1f78755	Ben Widawsky	acpi/spmc: Add support for the SPMC (Show More…)	Jul 30 2018, 11:27 PM
d34ca1f78755	29cba6903f63	e8e20c15781c	Ben Widawsky	acpi/lpit: Add basic support for the LPIT (Show More…)	Jul 30 2018, 11:16 PM
e8e20c15781c	2131322a3ae4	6d58cedf1fab	Ben Widawsky	Add a sysctl to query s0ix preference (Show More…)	Jun 26 2018, 6:33 PM

Status	Author	Revision
Needs Review	bwidawsk	D17676 Emulated S3 with s0ix (not currently working)
Needs Review	bwidawsk	D17675 Suspend to idle support
Closed	bwidawsk	D16635 Summary: acpi: fix acpi_ec_probe to only check EC devices