Page MenuHomeFreeBSD
Differential D14516

Only check the ProducerConsumer flag on extended memory
ClosedPublic
Actions

Authored by andrew on Feb 26 2018, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 28, 1:29 PM
Unknown Object (File)
Nov 21 2025, 8:37 AM
Unknown Object (File)
Nov 21 2025, 8:37 AM
Unknown Object (File)
Nov 21 2025, 8:36 AM
Unknown Object (File)
Nov 21 2025, 8:31 AM
Unknown Object (File)
Nov 7 2025, 5:02 AM
Unknown Object (File)
Oct 30 2025, 5:02 PM
Unknown Object (File)
Oct 25 2025, 7:37 PM
View All 67 Files
Subscribers
emaste
imp

Details

Reviewers
jkim
jhb
Commits
rS330113: Only check the ProducerConsumer flag on extended memory. As per the ACPI
Summary

As per the ACPI 6.0 spec 6.4.3.5 bit 0 is ignored on QWord, DWord, and Word
Address Space Descriptors, but not Extended Address Space Descriptors.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15274
Build 15333: arc lint + arc unit

Event Timeline

andrew created this revision.Feb 26 2018, 9:37 AM
Harbormaster completed remote builds in B15274: Diff 39740.Feb 26 2018, 9:37 AM
jhb accepted this revision.Feb 26 2018, 5:58 PM
jhb added inline comments.
sys/dev/acpica/acpi_resource.c
346

I would check res->Type first before checking the flag.

This revision is now accepted and ready to land.Feb 26 2018, 5:58 PM
Closed by commit rS330113: Only check the ProducerConsumer flag on extended memory. As per the ACPI (authored by andrew). · Explain WhyFeb 28 2018, 3:18 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2018, 3:18 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
3 lines

Diff 39740

View Options

sys/dev/acpica/acpi_resource.c

Loading...