Page MenuHomeFreeBSD

Add SPDX license tags for 4 Clause BSD Licensed files.
ClosedPublic

Authored by pfg on Nov 17 2017, 3:18 PM.

Details

Summary

SPDX is a new format to better hint the licenses used in source code
files.

Some years ago Wind River offered access to a cloud-based tool that scans
software licenses. Since then (r263093) some files have been removed, some
architectures have disappeared and other files have been relicensed.
Still, using that audit is a good starting point for proper license tagging.

Here is the result of checking for 4 Clause BSD licenses. Some of these
files could still be relicnes by checking the sources (particularly the
NetBSD guys).

Test Plan

Rebuildiong universe usually shows some obvious mistakes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I know this change is too big for a review but given that the BSD 4 Clause license is considered problematic for some it is rather good to have some reference on where it currently applies.

This is all done by hand and, for the record, we have a much bigger number of files under BSD 3 Clause license.

I spot checked about a dozen of these. I see no issues.

One thing that I worry about the crazy files that have 2 or 3 different licenses...

This revision is now accepted and ready to land.Nov 17 2017, 3:35 PM
In D13133#273041, @imp wrote:

I spot checked about a dozen of these. I see no issues.

One thing that I worry about the crazy files that have 2 or 3 different licenses...

It is not really a problem, SPDX permits AND and OR qualifiers, and there are some cases of that in this batch of changes. We should take the convenition of setting the most restrictive licenses on top, so that it is quicker to check the licensing and the consequences. I tried to keep the changes in this run small so I didn't do that yet.

We do have a problem when the license is not defined by SPDX. In such cases we users are expected to read the additional licensing. There is a procedures to submit new licenses to SPDX, I will look at that when I finish an initial phase of adding tags for known licenses.

Fix copy/pasto that broke the build.

This revision now requires review to proceed.Nov 18 2017, 12:14 AM

Spot checked these as well.

This revision is now accepted and ready to land.Nov 18 2017, 9:28 AM
This revision was automatically updated to reflect the committed changes.