Add SPDX license tags for 4 Clause BSD Licensed files.
ClosedPublic
Actions

Authored by pfg on Nov 17 2017, 3:18 PM.

Details

Reviewers

emaste
bcr
eadler
imp

Commits

rS325966: spdx: initial adoption of licensing ID tags.

Summary

SPDX is a new format to better hint the licenses used in source code
files.

Some years ago Wind River offered access to a cloud-based tool that scans
software licenses. Since then (r263093) some files have been removed, some
architectures have disappeared and other files have been relicensed.
Still, using that audit is a good starting point for proper license tagging.

Here is the result of checking for 4 Clause BSD licenses. Some of these
files could still be relicnes by checking the sources (particularly the
NetBSD guys).

Test Plan

Rebuildiong universe usually shows some obvious mistakes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pfg created this revision.Nov 17 2017, 3:18 PM

Harbormaster completed remote builds in B12812: Diff 35373.Nov 17 2017, 3:18 PM

Herald added subscribers: ae, jhibbits, rpokala and 2 others. · View Herald TranscriptNov 17 2017, 3:18 PM

I know this change is too big for a review but given that the BSD 4 Clause license is considered problematic for some it is rather good to have some reference on where it currently applies.

This is all done by hand and, for the record, we have a much bigger number of files under BSD 3 Clause license.

I spot checked about a dozen of these. I see no issues.

One thing that I worry about the crazy files that have 2 or 3 different licenses...

This revision is now accepted and ready to land.Nov 17 2017, 3:35 PM

In D13133#273041, @imp wrote:

I spot checked about a dozen of these. I see no issues.

One thing that I worry about the crazy files that have 2 or 3 different licenses...

It is not really a problem, SPDX permits AND and OR qualifiers, and there are some cases of that in this batch of changes. We should take the convenition of setting the most restrictive licenses on top, so that it is quicker to check the licensing and the consequences. I tried to keep the changes in this run small so I didn't do that yet.

We do have a problem when the license is not defined by SPDX. In such cases we users are expected to read the additional licensing. There is a procedures to submit new licenses to SPDX, I will look at that when I finish an initial phase of adding tags for known licenses.

Fix copy/pasto that broke the build.

This revision now requires review to proceed.Nov 18 2017, 12:14 AM

Spot checked these as well.

This revision is now accepted and ready to land.Nov 18 2017, 9:28 AM

Closed by commit rS325966: spdx: initial adoption of licensing ID tags. (authored by pfg). · Explain WhyNov 25 2017, 10:34 PM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 363 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

arm/

gen/

fabs.c

4 lines

locale/

euc.c

2 lines

mips/

SYS.h

2 lines

gen/

fabs.c

4 lines

net/

ether_addr.c

4 lines

rpc/

crypt_client.c

4 lines

libcam/

camlib.h

4 lines

scsi_cmdparse.c

5 lines

libkiconv/

xlat16_sysctl.c

4 lines

libprocstat/

2 lines

2 lines

2 lines

4 lines

librpcsvc/

yp_passwd.c

4 lines

yp_update.c

4 lines

libthr/

sys/

thr_error.c

4 lines

thread/

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

msun/

bsdsrc/

4 lines

4 lines

2 lines

4 lines

libexec/

mknetid/

hash.h

4 lines

hash.c

4 lines

mknetid.c

4 lines

revnetgroup/

hash.h

4 lines

hash.c

4 lines

revnetgroup.c

4 lines

ypxfr/

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

release/

picobsd/

tinyware/

pathnames.h

2 lines

pico-login.c

2 lines

passwd/

4 lines

2 lines

4 lines

2 lines

2 lines

2 lines

sbin/

bsdlabel/

bsdlabel.c

4 lines

etherswitchcfg/

ifmedia.c

4 lines

ffsinfo/

ffsinfo.c

4 lines

growfs/

debug.h

4 lines

debug.c

4 lines

growfs.c

4 lines

gvinum/

gvinum.h

2 lines

ifconfig/

ifmedia.c

4 lines

ifvlan.c

4 lines

rcorder/

4 lines

4 lines

4 lines

5 lines

sys/

amd64/

2 lines

2 lines

2 lines

2 lines

2 lines

ia32/

ia32_syscall.c

2 lines

include/

2 lines

2 lines

2 lines

2 lines

2 lines

arm/

autoconf.c

2 lines

in_cksum.c

2 lines

vm_machdep.c

2 lines

include/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

compat/

linprocfs/

linprocfs.c

2 lines

ndis/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

dev/

an/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

bge/

if_bge.c

2 lines

if_bgereg.h

2 lines

dc/

2 lines

2 lines

2 lines

2 lines

dcons/

2 lines

2 lines

2 lines

2 lines

2 lines

firewire/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

ic/

i82586.h

2 lines

if_ndis/

2 lines

2 lines

2 lines

2 lines

2 lines

lge/

if_lge.c

2 lines

if_lgereg.h

2 lines

mii/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

msk/

if_msk.c

2 lines

if_mskreg.h

2 lines

nge/

if_nge.c

2 lines

if_ngereg.h

2 lines

pcn/

if_pcn.c

2 lines

if_pcnreg.h

2 lines

ppbus/

lpt.c

2 lines

re/

if_re.c

2 lines

sf/

if_sf.c

2 lines

if_sfreg.h

2 lines

sge/

if_sge.c

2 lines

if_sgereg.h

2 lines

sis/

if_sis.c

2 lines

if_sisreg.h

2 lines

sk/

if_sk.c

2 lines

if_skreg.h

2 lines

xmaciireg.h

2 lines

ste/

if_ste.c

2 lines

if_stereg.h

2 lines

ti/

if_ti.c

2 lines

if_tireg.h

2 lines

tl/

if_tl.c

2 lines

if_tlreg.h

2 lines

txp/

if_txp.c

2 lines

usb/

net/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

vge/

if_vge.c

2 lines

if_vgereg.h

2 lines

if_vgevar.h

2 lines

vr/

if_vr.c

2 lines

if_vrreg.h

2 lines

wb/

if_wb.c

2 lines

if_wbreg.h

2 lines

wi/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

xl/

if_xl.c

2 lines

if_xlreg.h

2 lines

fs/

procfs/

procfs.c

2 lines

procfs_rlimit.c

2 lines

geom/

vinum/

geom_vinum_share.c

2 lines

geom_vinum_subr.c

2 lines

geom_vinum_var.h

4 lines

i386/

2 lines

2 lines

2 lines

2 lines

2 lines

ibcs2/

ibcs2_misc.c

2 lines

include/

floatingpoint.h

2 lines

ieeefp.h

2 lines

isa/

pnpreg.h

2 lines

kern/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

libkern/

strcasecmp.c

2 lines

strstr.c

2 lines

mips/

include/

2 lines

2 lines

2 lines

2 lines

mips/

db_disasm.c

2 lines

in_cksum.c

2 lines

sys_machdep.c

2 lines

net/

fddi.h

2 lines

if_arcsubr.c

2 lines

if_fddisubr.c

2 lines

netinet6/

ip6_id.c

2 lines

netsmb/

smb_crypt.c

2 lines

nfs/

bootp_subr.c

2 lines

krpc_subr.c

2 lines

powerpc/

fpu/

fpu_emu.c

4 lines

include/

_align.h

2 lines

_types.h

2 lines

param.h

2 lines

powerpc/

in_cksum.c

2 lines

vm_machdep.c

2 lines

riscv/

in_cksum.c

2 lines

pmap.c

2 lines

sparc64/

include/

cache.h

2 lines

sparc64/

cache.c

2 lines

eeprom.c

2 lines

sys/

2 lines

2 lines

2 lines

2 lines

2 lines

vm/

2 lines

2 lines

2 lines

2 lines

x86/

include/

_align.h

2 lines

_types.h

2 lines

tools/

regression/

p1003_1b/

4 lines

4 lines

4 lines

4 lines

4 lines

usr.bin/

chpass/

4 lines

2 lines

2 lines

4 lines

2 lines

diff/

diffreg.c

4 lines

indent/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

locate/

bigram/

locate.bigram.c

2 lines

code/

locate.code.c

2 lines

locate/

2 lines

2 lines

2 lines

2 lines

2 lines

netstat/

mbuf.c

2 lines

mroute.c

2 lines

mroute6.c

2 lines

pr/

2 lines

2 lines

2 lines

2 lines

rup/

rup.c

2 lines

rusers/

rusers.c

2 lines

rwall/

rwall.c

4 lines

truss/

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

2 lines

4 lines

2 lines

4 lines

4 lines

uname/

uname.c

2 lines

usr.sbin/

ancontrol/

ancontrol.c

4 lines

dconschat/

dconschat.c

4 lines

fwcontrol/

fwcontrol.c

4 lines

fwdv.c

4 lines

fwmpegts.c

4 lines

kldxref/

ef.c

4 lines

ef_obj.c

4 lines

kldxref.c

4 lines

lpr/

common_source/

common.c

4 lines

net.c

4 lines

printcap.c

4 lines

lpr/

lpr.c

4 lines

makefs/

ffs.c

4 lines

manctl/

manctl.sh

2 lines

ndiscvt/

4 lines

4 lines

4 lines

2 lines

2 lines

2 lines

rpc.lockd/

4 lines

4 lines

4 lines

4 lines

rpc.statd/

4 lines

4 lines

4 lines

4 lines

rpc.yppasswdd/

yppasswdd_extern.h

4 lines

yppasswdd_main.c

2 lines

yppasswdd_server.c

4 lines

rpc.ypupdated/

4 lines

4 lines

4 lines

4 lines

rpc.ypxfrd/

ypxfrd_extern.h

4 lines

ypxfrd_main.c

4 lines

ypxfrd_server.c

4 lines

rrenumd/

rrenumd.h

4 lines

wpa/

ndis_events/

ndis_events.c

2 lines

wpa_supplicant/

Packet32.h

2 lines

Packet32.c

2 lines

yp_mkdb/

yp_mkdb.c

4 lines

ypbind/

yp_ping.c

2 lines

yppush/

yppush_main.c

4 lines

ypserv/

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

4 lines

Add SPDX license tags for 4 Clause BSD Licensed files.ClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 35787

head/lib/libc/arm/gen/fabs.c

head/lib/libc/locale/euc.c

head/lib/libc/mips/SYS.h

head/lib/libc/mips/gen/fabs.c

head/lib/libc/net/ether_addr.c

head/lib/libc/rpc/crypt_client.c

head/lib/libcam/camlib.h

head/lib/libcam/scsi_cmdparse.c

head/lib/libkiconv/xlat16_sysctl.c

head/lib/libprocstat/cd9660.c

head/lib/libprocstat/common_kvm.c

head/lib/libprocstat/libprocstat.c

head/lib/libprocstat/msdosfs.c

head/lib/librpcsvc/yp_passwd.c

head/lib/librpcsvc/yp_update.c

head/lib/libthr/sys/thr_error.c

head/lib/libthr/thread/thr_attr.c

head/lib/libthr/thread/thr_autoinit.c

head/lib/libthr/thread/thr_concurrency.c

head/lib/libthr/thread/thr_getschedparam.c

head/lib/libthr/thread/thr_init.c

head/lib/libthr/thread/thr_mutex.c

head/lib/libthr/thread/thr_setschedparam.c

head/lib/libthr/thread/thr_switch_np.c

head/lib/msun/bsdsrc/b_exp.c

head/lib/msun/bsdsrc/b_log.c

head/lib/msun/bsdsrc/b_tgamma.c

head/lib/msun/bsdsrc/mathimpl.h

head/libexec/mknetid/hash.h

head/libexec/mknetid/hash.c

head/libexec/mknetid/mknetid.c

head/libexec/revnetgroup/hash.h

head/libexec/revnetgroup/hash.c

head/libexec/revnetgroup/revnetgroup.c

head/libexec/ypxfr/yp_dbwrite.c

head/libexec/ypxfr/ypxfr_extern.h

head/libexec/ypxfr/ypxfr_getmap.c

head/libexec/ypxfr/ypxfr_main.c

head/libexec/ypxfr/ypxfr_misc.c

head/libexec/ypxfr/ypxfrd_getmap.c

head/release/picobsd/tinyware/login/pathnames.h

head/release/picobsd/tinyware/login/pico-login.c

head/release/picobsd/tinyware/passwd/extern.h

head/release/picobsd/tinyware/passwd/local_passwd.c

head/release/picobsd/tinyware/passwd/passwd.c

head/release/picobsd/tinyware/passwd/pw_copy.c

head/release/picobsd/tinyware/passwd/pw_util.h

head/release/picobsd/tinyware/passwd/pw_util.c

head/sbin/bsdlabel/bsdlabel.c

head/sbin/etherswitchcfg/ifmedia.c

head/sbin/ffsinfo/ffsinfo.c

head/sbin/growfs/debug.h

head/sbin/growfs/debug.c

head/sbin/growfs/growfs.c

head/sbin/gvinum/gvinum.h

head/sbin/ifconfig/ifmedia.c

head/sbin/ifconfig/ifvlan.c

head/sbin/rcorder/ealloc.c

head/sbin/rcorder/hash.h

head/sbin/rcorder/hash.c

head/sbin/rcorder/sprite.h

head/sys/amd64/amd64/in_cksum.c

head/sys/amd64/amd64/machdep.c

head/sys/amd64/amd64/pmap.c

head/sys/amd64/amd64/trap.c

head/sys/amd64/amd64/vm_machdep.c

head/sys/amd64/ia32/ia32_syscall.c

head/sys/amd64/include/floatingpoint.h

head/sys/amd64/include/ieeefp.h

head/sys/amd64/include/param.h

head/sys/amd64/include/varargs.h

head/sys/amd64/include/vmparam.h

head/sys/arm/arm/autoconf.c

Add SPDX license tags for 4 Clause BSD Licensed files.
ClosedPublic
Actions

Revision Contents
Changeset List