address ngie comment

fix man page

Thanks for tagging me!

make sure it builds on top of -head again, then ship it! heh

split change

Ok, this is weird... This is actually a "Apple S3X NVMe Controller". I'll look at the logic carefully and see if something's awry here.

In D57087#1339149, @guest-seuros wrote:

Before we touch code, please boot to macos and let it update the firmware.

A Lot of time i found bugs in apple hardware, tougth it was quirk, then could not reproduce it once the firmware was updated. (just install the latest version possible, the update flow , update the EFI, SMC and firmwares ...

I bought a 2016 macbook, i will receive it this week. I suspect we need to handle T1.

PS: this quirk is needed for every 2018-2020 computer.

Before we touch code, please boot to macos and let it update the firmware.

This is T1 macbook. which is a model that was released in late 2016 to late2017 , then replaced with the T2 in 2018-2020

This change causes my non-T2 MacBook Pro ('16 MBP) to panic at boot with "received completion for unknown cmd": https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296946 .

looks good, will compile test it later before landing, thanks!

address comment

refactor

The other diff is how i verified that this change worked, it is not a requirement.

@guest-seuros: can this change land independent of D57853?

addressing review