Sat, Jul 25
Fri, Jul 24
Wed, Jul 22
Ok, this is weird... This is actually a "Apple S3X NVMe Controller". I'll look at the logic carefully and see if something's awry here.
Tue, Jul 21
Before we touch code, please boot to macos and let it update the firmware.
This is T1 macbook. which is a model that was released in late 2016 to late2017 , then replaced with the T2 in 2018-2020
This change causes my non-T2 MacBook Pro ('16 MBP) to panic at boot with "received completion for unknown cmd": https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296946 .
Wed, Jul 1
Jun 28 2026
Jun 27 2026
looks good, will compile test it later before landing, thanks!
address comment
refactor
The other diff is how i verified that this change worked, it is not a requirement.
@guest-seuros: can this change land independent of D57853?
addressing review
Jun 26 2026
Jun 25 2026
I'm splitting them into 3 into a stack.
splitting
oh and i think you should split this into two parts:
