acpi_apple: make the device mode a typed enum
ClosedPublic
Actions

Authored by seuros on Sat, Oct 17, 1:18 AM.

Details

Reviewers

Commits

rG4a059dac7815: acpi_apple: make the device mode a typed enum

Summary

The two mode values were spelled as bit flags, but a device is exactly
one of the two and the dispatch compared the field for equality.

Turned them into an enum, type the softc field with it, and dispatch with
a switch that lists every value

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros created this revision.Sat, Oct 17, 1:18 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 17, 1:18 AM

seuros requested review of this revision.Sat, Oct 17, 1:18 AM

Harbormaster completed remote builds in B78284: Diff 190088.Sat, Oct 17, 1:18 AM

seuros added a parent revision: D60792: acpi_apple: rename source files to match the driver name.Sat, Oct 17, 1:19 AM

seuros added projects: drivers, apple (x86).

adrian accepted this revision.Sat, Oct 17, 6:24 PM

This revision is now accepted and ready to land.Sat, Oct 17, 6:24 PM

Closed by commit rG4a059dac7815: acpi_apple: make the device mode a typed enum (authored by seuros). · Explain WhySat, Oct 17, 7:50 PM

This revision was automatically updated to reflect the committed changes.

seuros added a commit: rG4a059dac7815: acpi_apple: make the device mode a typed enum.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpi_apple/

acpi_apple.h

8 lines

acpi_apple.c

15 lines

Diff 190138

View Options

sys/dev/acpi_apple/acpi_apple.h