Differential D57854

asmc: deduplicate sensor converters and cause sysctls
ClosedPublic
Actions

Authored by guest-seuros on Thu, Jun 25, 9:57 PM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Jul 6, 12:55 AM

	Unknown Object (File)
	Sun, Jul 5, 10:34 PM

	Unknown Object (File)
	Sat, Jul 4, 8:42 PM

	Unknown Object (File)
	Sat, Jul 4, 6:43 AM

	Unknown Object (File)
	Sat, Jul 4, 6:34 AM

	Unknown Object (File)
	Sat, Jul 4, 5:30 AM

	Unknown Object (File)
	Sat, Jul 4, 4:43 AM

	Unknown Object (File)
	Thu, Jul 2, 7:52 PM

Subscribers

Details

Reviewers

Commits

rG126f82a3eb61: asmc: deduplicate sensor converters and cause sysctls

Summary

Replace per-type spXX_to_milli() functions with a table-driven
asmc_sensor_convert() that looks up the divisor by SMC type string.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Thu, Jun 25, 9:57 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 25, 9:57 PM

guest-seuros requested review of this revision.Thu, Jun 25, 9:57 PM

Harbormaster completed remote builds in B74268: Diff 180651.Thu, Jun 25, 9:57 PM

guest-seuros added a parent revision: D57853: asmc: add system state and board identity sysctls.Thu, Jun 25, 9:58 PM

guest-seuros added projects: apple (x86), drivers.

adrian accepted this revision.Fri, Jun 26, 10:39 PM

This revision is now accepted and ready to land.Fri, Jun 26, 10:39 PM

refactor

This revision now requires review to proceed.Sat, Jun 27, 10:38 PM

Harbormaster completed remote builds in B74342: Diff 180841.Sat, Jun 27, 10:38 PM

adrian accepted this revision.Sat, Jun 27, 11:39 PM

adrian added inline comments.

sys/dev/asmc/asmc.c
2595	oh interesting, is this handling key differences between sleep and non-sleep stuff? what did the old code do? Just assume MSSP always, right?

This revision is now accepted and ready to land.Sat, Jun 27, 11:39 PM

guest-seuros marked an inline comment as done.Sun, Jun 28, 12:21 AM

guest-seuros added inline comments.

sys/dev/asmc/asmc.c
2595	The old code had two separate handlers each hardcoded to its own key and is_sleep flag. The diff merged them into one handler using arg2 as params. No new logic was introduced in this diff.

Closed by commit rG126f82a3eb61: asmc: deduplicate sensor converters and cause sysctls (authored by guest-seuros, committed by adrian). · Explain WhyWed, Jul 1, 12:21 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG126f82a3eb61: asmc: deduplicate sensor converters and cause sysctls.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

153 lines

Diff 181131

sys/dev/asmc/asmc.c

Loading...