firstly we'd be changing the KBI (I think) on systems where sizeof(unsigned int) != size_t.

Remove loc=left hint for Lenovos

Remove duplicate config files and replace them with symlinks

FreeBSD uses native uuid_t only in ACPI and GEOM(EFI) subsystems.

Created & implemented crc16.h, there are some new functions which I could not find already implemented in the FreeBSD base system

Put the comment for the commit message in the code itself.

LGTM. Move uuid_t definition to guid_t definition.

If you mark the requested change "done"

Some nits:

1. List of unsupported firmware files that can be deleted:

pdev->pdrv == NULL check added.

• Please import all supported firmwares. See rtlbt_fw.cc for the list.
• Install firmwares to /usr/share/firmware/rtlbt rather than to /usr/share/firmware to not produce mess.
• Add LICENSE file from rtwn

vertical space (blank line) is removed

return ERR_PTR(-ENOMEM) if devres_alloc() has failed

oops.

Add __UNIQUE_ID_ prefix per @bz request

bool argument for dma added

LGTM.
All SPI_LYNXPOINT IDs are included in Linux PXA2 driver. See cat drivers/spi/spi-pxa2xx-pci.c | grep '^#.*PCI_DEVICE_ID_INTEL_' output
All SPI_SUNRISEPOINT IDs are included in Linux LPSS driver. See cat drivers/mfd/intel-lpss-pci.c | grep PCI_VDEVICE | grep _spi_ output

In D57782#1352915, @wulf wrote:

I rechecked 530462939f6 again. It seems that irqs_disabled() never used in drm-kmod for spin_locks. So I am ok for old drm-kmod version of this review.

I rechecked 530462939f6 again. It seems that irqs_disabled() never used in drm-kmod for spin_locks. So I am ok for old drm-kmod version of this review.

And do not revert linux/kernel.h part of 530462939f6 irqs_disabled() should stay in in-base LKPI

What was the motivation of that change originally?

LGTM

I was able to test one of the Yubikeys reported as broken earlier. It looks to work now.

In D57488#1320152, @bz wrote:

In D57488#1317279, @wulf wrote:

In D57488#1317060, @bz wrote:

Forgive my lack of knowledge:

(a) what is using this interface in FreeBSD?

udl(4) and inbase legacy drm. Formerly it served for i915kms and amdgpu but now for nvidia tegra only

Do we also need this code for the vt switch in case of panic?

In D57488#1317060, @bz wrote:

Forgive my lack of knowledge:

(a) what is using this interface in FreeBSD?

LGTM

I committed mmap()-based changes. See: https://cgit.freebsd.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7

Although it looks good, replacing read() with mmap() -> memcpy() -> munmap() sequence would make code simpler and cleaner