In D50498#1153913, @aokblast wrote:

@wulf Are you still have concern on the read_kbd_data? If not, I plan to create the patch for merging.

Should we cache read_kbd_data() rather than reread it?

In D50315#1150660, @markj wrote:

In D50315#1150102, @wulf wrote:

In D50315#1149915, @markj wrote:

In D50315#1149724, @arrowd wrote:

In test "Bugfix tests":

failed: receive IN_ATTRIB for bugst-workdir/1 on hardlink delete
failed: Not receive IN_DELETE_SELF for bugst-workdir/1 on hardlink delete

This one is tricky to fix, I need to think about it.

IIRC IN_DELETE_SELF is generated when the file link number goes from 1 to 0

Some laptops powers radio module even they are switched off. You may try to reinsert wireless card or discharge battery.

In D50066#1141903, @aokblast wrote:

1. You have 1 patch for v2 header so I can abandon this patch?

It broke bt adaptor for me at first early version run too due to bug in rtlbt_load_fwfile() which is fixed in my version now

I am about to commit V2 firmware support. It worked for me with at least one 8852CE adaptor. just test it.

LGTM
Please add 2 more I2C device:

4dc5  Jasper Lake Serial IO I2C Host Controller #4
4dc6  Jasper Lake Serial IO I2C Host Controller #5

I was not able to read nor RGB mode nor Thermal policy from BIOS

In D48983#1117257, @mav wrote:

I have no objections, but I wonder whether maximum of 3 vs 7 might be model-specific?

Fix manpage and braces

Fix description and stray newline

In D49002#1117625, @christos wrote:

The commit message says "ALC257 codecs initialization", but in hdaa_patch_direct() and in pin_patch_realtek.h we seem to be affecting other codecs as well. Shouldn't the commit message reflect that?

In D48941#1116640, @zlei wrote:

Emm, I did not realize that a prior work exists. Should I continue working on this one, or wait for D34252 ?

Add private mutex to synchronize interrupt handler with driver attach function
while waiting for RESET command response.

Ooops. last minute braino. I take Giant from ithread. I will fix it.

There is prior work to fix that D34252