I was not able to read nor RGB mode nor Thermal policy from BIOS

In D48983#1117257, @mav wrote:

I have no objections, but I wonder whether maximum of 3 vs 7 might be model-specific?

Fix manpage and braces

Fix description and stray newline

In D49002#1117625, @christos wrote:

The commit message says "ALC257 codecs initialization", but in hdaa_patch_direct() and in pin_patch_realtek.h we seem to be affecting other codecs as well. Shouldn't the commit message reflect that?

In D48941#1116640, @zlei wrote:

Emm, I did not realize that a prior work exists. Should I continue working on this one, or wait for D34252 ?

Add private mutex to synchronize interrupt handler with driver attach function
while waiting for RESET command response.

Ooops. last minute braino. I take Giant from ithread. I will fix it.

There is prior work to fix that D34252

In D47682#1087414, @bz wrote:

I would love that but @manu or @wulf or someone would have to fix the gpu-firmware bits for this. I noticed yesterday that it's still shipping .ko files.

LGTM

Update to react on comments

I am sorry for delay with review

It works good on Intel Skylake

Heh, this broke build of drm-kmod's master branch:

/home/wulf/dvp/drm-kmod/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:187:15: error: expression result unused [-Werror,-Wunused-value]
  187 |         if (unlikely(rcu_dereference_protected(*ptr, 1))) {
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wulf/dvp/freebsd/wulf/sys/compat/linuxkpi/common/include/linux/rcupdate.h:115:5: note: expanded from macro 'rcu_dereference_protected'
  115 |     __rcu_dereference_protected((p), (c),                               \
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  116 |         __rcu_var_name(protected, __func__, __LINE__))
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wulf/dvp/freebsd/wulf/sys/compat/linuxkpi/common/include/linux/rcupdate.h:109:5: note: expanded from macro '__rcu_dereference_protected'
  109 |     RCU_WARN_ONCE(!(c), "%s:%d: condition for %s failed\n",             \
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  110 |         __func__, __LINE__, __XSTRING(n));                              \
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wulf/dvp/freebsd/wulf/sys/compat/linuxkpi/common/include/linux/rcupdate.h:45:3: note: expanded from macro 'RCU_WARN_ONCE'
   45 |                 1;                                                      \
      |                 ^
/home/wulf/dvp/freebsd/wulf/sys/compat/linuxkpi/common/include/linux/compiler.h:82:43: note: expanded from macro 'unlikely'
   82 | #define unlikely(x)                     __builtin_expect(!!(x), 0)

The only note: It looks that rcu_read_lock_held() always returns true on non-debug builds: https://elixir.bootlin.com/linux/v6.11.3/source/include/linux/rcupdate.h#L351

5. Linux name of this routine is (s)rcu_read_lock_held

In D47006#1071711, @bz wrote:

In D47006#1071395, @ashafer_badland.io wrote:

What's preventing rtw89 from getting enabled in the build? With this fix I could comfortably test youtube, iperf3, ssh. Speed was ~20mbps but stable. I think it could make sense to open this up to more people.

Blockers like what @misha fixed and possibly thins one. I've got drivers updates pending which may or may not restart some of this process; I haven't tested but I have locally enabled rtw89.

In D46740#1065788, @diizzy wrote:

I'm not a fan of this approach simply because we're relying on another distro to package things and it's a bit kludgy too.
We can utilize https://gitlab.com/kernel-firmware/linux-firmware and GitLab helper however the distrofile would be quite large however it might be a better idea to make a meta-port and slave/subports.
Another approach, https://www.freshports.org/net/wifi-firmware-kmod

Add #define for UBT_INTEL_TLV_IMAGE_TYPE

Implementation is incomplete and not used in drm-kmod currently

In D44861#1052291, @bz wrote:

If you open dedicated reviews for these leave the numbers here; I might even have a look.