Page MenuHomeFreeBSD

wulf (Vladimir Kondratyev)
User

Projects

User Details

User Since
Jun 3 2017, 8:47 AM (436 w, 1 d)

Recent Activity

Mon, Sep 29

wulf committed rGee46f649cb13: ietp(4): Always overload HID report descriptor (authored by wulf).
ietp(4): Always overload HID report descriptor
Mon, Sep 29, 9:53 PM
wulf committed rGc18032ba3172: iichid(4): Always use wMaxInputLength bytes as input report length (authored by wulf).
iichid(4): Always use wMaxInputLength bytes as input report length
Mon, Sep 29, 9:53 PM
wulf committed rG9c61c3f7e4b1: iichid(4): Do not add 2 leading "length" bytes to input report length (authored by wulf).
iichid(4): Do not add 2 leading "length" bytes to input report length
Mon, Sep 29, 9:53 PM

Sat, Sep 27

wulf committed rG64b530b38be3: u2f(4): Invert U2F_MAKE_UHID_ALIAS kernel build option (authored by wulf).
u2f(4): Invert U2F_MAKE_UHID_ALIAS kernel build option
Sat, Sep 27, 10:28 AM
wulf committed rGd82a9494e798: u2f(4): Use taskqueue to start USB transfers from kqueue context (authored by wulf).
u2f(4): Use taskqueue to start USB transfers from kqueue context
Sat, Sep 27, 10:28 AM

Thu, Sep 25

wulf committed rG186e433300fe: u2f(4): Use taskqueue to start USB transfers from kqueue context (authored by wulf).
u2f(4): Use taskqueue to start USB transfers from kqueue context
Thu, Sep 25, 7:56 AM
wulf committed rGe43fbf27976d: u2f(4): Invert U2F_MAKE_UHID_ALIAS kernel build option (authored by wulf).
u2f(4): Invert U2F_MAKE_UHID_ALIAS kernel build option
Thu, Sep 25, 7:56 AM

Wed, Sep 24

wulf committed rG1bc5c9a23225: rc.d/moused: Fix misplaced `basename` (authored by wulf).
rc.d/moused: Fix misplaced `basename`
Wed, Sep 24, 7:44 AM

Tue, Sep 23

wulf committed rGf586fc0cf8ff: rc.d/moused: Fix misplaced `basename` (authored by wulf).
rc.d/moused: Fix misplaced `basename`
Tue, Sep 23, 8:38 AM

Mon, Sep 22

wulf committed rGa4417b9f9cde: moused(8): Start moused with devd (authored by wulf).
moused(8): Start moused with devd
Mon, Sep 22, 9:26 AM
wulf committed rGd5f63d6b3738: moused(8): Add command line option to restrict interface type (authored by wulf).
moused(8): Add command line option to restrict interface type
Mon, Sep 22, 9:26 AM
wulf committed rG1e74951b6cd8: iichid(4): Do not add 2 leading "length" bytes to input report length (authored by wulf).
iichid(4): Do not add 2 leading "length" bytes to input report length
Mon, Sep 22, 8:39 AM
wulf committed rG8f496952e3e6: iichid(4): Always use wMaxInputLength bytes as input report length (authored by wulf).
iichid(4): Always use wMaxInputLength bytes as input report length
Mon, Sep 22, 8:38 AM
wulf committed rGa9227954b0f0: ietp(4): Always overload HID report descriptor (authored by wulf).
ietp(4): Always overload HID report descriptor
Mon, Sep 22, 8:38 AM

Sun, Sep 21

wulf committed rG66e7f048f0c8: moused(8): Start moused with devd (authored by wulf).
moused(8): Start moused with devd
Sun, Sep 21, 1:17 PM
wulf committed rG1335bf5ce1c9: moused(8): Add command line option to restrict interface type (authored by wulf).
moused(8): Add command line option to restrict interface type
Sun, Sep 21, 1:17 PM
wulf closed D52430: moused(8): Enable sysmouse-compatibility mode by default..
Sun, Sep 21, 1:16 PM
wulf closed D52647: moused(8): Add command line option to restrict interface type.
Sun, Sep 21, 1:16 PM

Sat, Sep 20

wulf updated the diff for D52430: moused(8): Enable sysmouse-compatibility mode by default..

Drop moused.conf hacks.

Sat, Sep 20, 9:24 PM
wulf requested review of D52647: moused(8): Add command line option to restrict interface type.
Sat, Sep 20, 9:22 PM
wulf updated the diff for D52430: moused(8): Enable sysmouse-compatibility mode by default..

Run moused with devd

Sat, Sep 20, 1:41 PM

Sep 8 2025

wulf requested review of D52430: moused(8): Enable sysmouse-compatibility mode by default..
Sep 8 2025, 8:31 PM

Sep 6 2025

wulf accepted D52324: bluetooth: ng_ubt_rtl/rtlbtfw: remove duplicate entry in device table.

I have no strong opinion if this right or not. This list is derived from Linux driver with no modifications.
Probably, it has many more duplications. All vendor "0x0bda" devices are handled by generic Realtek entry.

Sep 6 2025, 1:50 AM

Sep 4 2025

wulf added a comment to D52164: moused(8): Add support for evdev protocol.

I will try to address comments on weekend

Sep 4 2025, 9:15 PM
wulf committed rG641f525a87c9: cyapa(4): Add support for reporting data with sysmouse protocol (authored by wulf).
cyapa(4): Add support for reporting data with sysmouse protocol
Sep 4 2025, 9:14 PM
wulf committed rGaef807876c30: moused(8): Add support for evdev protocol (authored by wulf).
moused(8): Add support for evdev protocol
Sep 4 2025, 9:14 PM
wulf closed D52164: moused(8): Add support for evdev protocol.
Sep 4 2025, 9:14 PM

Aug 30 2025

wulf accepted D51585: acpi_gpiobus: implement bus_child_deleted.
Aug 30 2025, 11:29 AM

Aug 27 2025

wulf updated the diff for D52164: moused(8): Add support for evdev protocol.

Fix paths in msconvd rc script

Aug 27 2025, 7:19 PM
wulf added a comment to D52164: moused(8): Add support for evdev protocol.

Is this the one Yusuf and I have been testing from your GitHub?

Aug 27 2025, 1:33 AM

Aug 26 2025

wulf added a comment to D52164: moused(8): Add support for evdev protocol.

I know about a dozen of persons who tested it.

Aug 26 2025, 1:11 PM
wulf requested review of D52164: moused(8): Add support for evdev protocol.
Aug 26 2025, 12:38 PM

Aug 22 2025

wulf accepted D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.
Aug 22 2025, 10:21 AM

Aug 18 2025

wulf accepted D52000: u2f.4: Polish.

LGTM

Aug 18 2025, 8:34 PM
wulf abandoned D41639: Add u2f(4), a HID driver for FIDO/U2F security keys.

Committed as 4a04e0a6

Aug 18 2025, 10:33 AM

Aug 17 2025

wulf abandoned D48960: gpioaei: Add support for ACPI _EVT method.

Committed as adc2c156acb50bac6e8ec66b72cadc8910ce4975

Aug 17 2025, 9:10 PM
wulf committed rG4a04e0a6c703: u2f(4): a HID driver for FIDO/U2F security keys (authored by wulf).
u2f(4): a HID driver for FIDO/U2F security keys
Aug 17 2025, 9:04 PM
wulf committed rGe06d0350ec42: NOTES: improve HIDRAW_MAKE_UHID_ALIAS description (authored by wulf).
NOTES: improve HIDRAW_MAKE_UHID_ALIAS description
Aug 17 2025, 9:04 PM
wulf committed rG37e3b6646692: usbhid(4): Implement USB_GET_DEVICEINFO ioctl (authored by wulf).
usbhid(4): Implement USB_GET_DEVICEINFO ioctl
Aug 17 2025, 9:04 PM
wulf closed D51612: u2f(4): a HID driver for FIDO/U2F security keys.
Aug 17 2025, 9:04 PM
wulf closed D51611: NOTES: improve HIDRAW_MAKE_UHID_ALIAS description.
Aug 17 2025, 9:04 PM
wulf committed rG149b9f26d0ba: hidraw(4): Rename to uhid if HIDRAW_MAKE_UHID_ALIAS is specified (authored by wulf).
hidraw(4): Rename to uhid if HIDRAW_MAKE_UHID_ALIAS is specified
Aug 17 2025, 9:04 PM
wulf closed D51609: usbhid(4): Implement USB_GET_DEVICEINFO ioctl.
Aug 17 2025, 9:04 PM
wulf closed D51608: hidraw(4): Rename to uhid if HIDRAW_MAKE_UHID_ALIAS is specified.
Aug 17 2025, 9:04 PM
wulf committed rGd3d92388a54c: sys/conf.h: Add u2f group id to use in coming FIDO/U2F driver (authored by wulf).
sys/conf.h: Add u2f group id to use in coming FIDO/U2F driver
Aug 17 2025, 9:03 PM
wulf closed D51607: sys/conf.h: Add u2f group id to use in coming FIDO/U2F driver.
Aug 17 2025, 9:03 PM
wulf closed D51606: hid: Allow serial execution of HID_INTR_START method..
Aug 17 2025, 9:03 PM
wulf committed rGdf6ae0577d2c: hid: Allow serial execution of HID_INTR_START method. (authored by wulf).
hid: Allow serial execution of HID_INTR_START method.
Aug 17 2025, 9:03 PM
wulf closed D51605: hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4).
Aug 17 2025, 9:03 PM
wulf committed rG7699ec1558b7: hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4) (authored by wulf).
hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)
Aug 17 2025, 9:03 PM

Aug 12 2025

wulf added inline comments to D51606: hid: Allow serial execution of HID_INTR_START method..
Aug 12 2025, 10:45 PM

Jul 30 2025

wulf retitled D51606: hid: Allow serial execution of HID_INTR_START method. from hid: Allow serial execution of HID_INTR_STOP method. to hid: Allow serial execution of HID_INTR_START method..
Jul 30 2025, 6:22 PM
wulf added a comment to D45659: Enable usbhid by default.

IMO we can go forward and commit this change before code slush..
FIDO/U2F driver is under review. And moused is in a good enough shape to be widely tested. Both of them are minor changes and i think can be committed after August 8.

Jul 30 2025, 6:02 PM

Jul 29 2025

wulf committed rG6296dd08ae52: Added identifiers for additional PS4 DualShock controller variants (authored by Kevin Reinholz <kreinholz@gmail.com>).
Added identifiers for additional PS4 DualShock controller variants
Jul 29 2025, 10:17 PM
wulf committed rG6a11b6aed8a9: psm(4): Add kqueue support (authored by wulf).
psm(4): Add kqueue support
Jul 29 2025, 10:17 PM
wulf committed rG2100a0fecec7: rtlbtfw(8): Sync device VID/PID list with Linux 6.15-rc4 (authored by wulf).
rtlbtfw(8): Sync device VID/PID list with Linux 6.15-rc4
Jul 29 2025, 10:17 PM
wulf committed rG08ad5c42343b: rtlbtfw(8): Add support for firmware file format V2 (authored by wulf).
rtlbtfw(8): Add support for firmware file format V2
Jul 29 2025, 10:17 PM

Jul 28 2025

wulf added a comment to D51609: usbhid(4): Implement USB_GET_DEVICEINFO ioctl.

This is identical to D50550, right? Sorry I didn't make it further in separating these parts as you've done; I'll abandon D50550 and you can land this in this series.

Jul 28 2025, 10:55 PM
wulf accepted D51302: Avoid split I²C transactions in iichid.

LGTM

Jul 28 2025, 10:52 PM · Src Committers
wulf abandoned D51610: Add u2f(4), a HID driver for FIDO/U2F security keys.

Duplicate of D51612

Jul 28 2025, 9:39 PM
wulf requested review of D51612: u2f(4): a HID driver for FIDO/U2F security keys.
Jul 28 2025, 9:38 PM
wulf requested review of D51611: NOTES: improve HIDRAW_MAKE_UHID_ALIAS description.
Jul 28 2025, 9:36 PM
wulf requested review of D51610: Add u2f(4), a HID driver for FIDO/U2F security keys.
Jul 28 2025, 9:32 PM
wulf requested review of D51609: usbhid(4): Implement USB_GET_DEVICEINFO ioctl.
Jul 28 2025, 9:32 PM
wulf requested review of D51608: hidraw(4): Rename to uhid if HIDRAW_MAKE_UHID_ALIAS is specified.
Jul 28 2025, 9:31 PM
wulf requested review of D51607: sys/conf.h: Add u2f group id to use in coming FIDO/U2F driver.
Jul 28 2025, 9:31 PM
wulf requested review of D51606: hid: Allow serial execution of HID_INTR_START method..
Jul 28 2025, 9:30 PM
wulf requested review of D51605: hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4).
Jul 28 2025, 9:29 PM

Jul 11 2025

wulf accepted D51236: acpi_gpiobus: don't print error message if _AEI object doesn't exist.
Jul 11 2025, 8:56 AM

Jul 6 2025

wulf accepted D51107: ichiic: Add PCI id for Arrow Lake..
Jul 6 2025, 10:30 AM

Jul 2 2025

wulf added a comment to D51107: ichiic: Add PCI id for Arrow Lake..

There are more ArrowLake I2C device ids: 7750 and 7751. At least in share/misc/pci_vendors

According to the Datasheet, I2C#4(7750),I2C#5(7751) only supports PIO mode, and I'm not sure the PIO mode only device will work or not.

https://edc.intel.com/content/www/us/en/design/products-and-solutions/processors-and-chipsets/core-ultra-200h-and-200u-series-processors-datasheet-volume-1-of-2/intel-serial-i-o-inter-integrated-circuit-i2c-controllers/

Jul 2 2025, 8:33 AM

Jul 1 2025

wulf added a comment to D51107: ichiic: Add PCI id for Arrow Lake..

There are more ArrowLake I2C device ids: 7750 and 7751. At least in share/misc/pci_vendors

Jul 1 2025, 6:44 PM

Jun 26 2025

wulf committed rGb93063c84e4e: psm(4): Add kqueue support (authored by wulf).
psm(4): Add kqueue support
Jun 26 2025, 9:28 PM

Jun 25 2025

wulf accepted D50871: gpiopps: don't use internal gpiobus function.

LGTM

Jun 25 2025, 8:32 AM
wulf accepted D50872: gpio: hide internal gpiobus symbols.

LGTM

Jun 25 2025, 8:23 AM

Jun 15 2025

wulf accepted D50863: LinuxKPI: acpi: provide union [linuxkpi]_acpi_(object|buffer).

As number of object types we handle in LKPI does not exceed 10 it may counts as not a rewrite of ACPICA

Jun 15 2025, 6:13 PM
wulf added a comment to D50863: LinuxKPI: acpi: provide union [linuxkpi]_acpi_(object|buffer).
In D50863#1161018, @imp wrote:
In D50863#1161016, @imp wrote:

Proper compat symbols will also make future ports easier

It is not about of proper symbols. It is about of adding of LKPI objects which differs only in character case in the name

Which is just as trivial to paper over with #defines so you don't have to change it next time which makes future ports faster since you don't have to detour around already solved trivial problems. When I've done it for other things in the tree, it's helped prevent death of a thousand cuts...

Jun 15 2025, 6:01 PM
wulf added a comment to D50863: LinuxKPI: acpi: provide union [linuxkpi]_acpi_(object|buffer).
In D50863#1161016, @imp wrote:

Proper compat symbols will also make future ports easier

Jun 15 2025, 5:50 PM
wulf added a comment to D50863: LinuxKPI: acpi: provide union [linuxkpi]_acpi_(object|buffer).
In D50863#1161012, @bz wrote:

General convention in at least drm-kmod is to not redefine ACPICA objects if it is possible. Porting of this code is mostly just a changing of symbol case and adding/removing of underscores. drm-kmod does not even guards these changes with #ifdefs

I picked a random file ( in v6.6 drivers/gpu/drm/radeon/radeon_acpi.c ) and it seems everything there got CamelCased without any #ifdefs. It's just an unnecessary diff to vendor and maintenance.

No idea how much of this was done in drm-kmod but I am not going to rewrite case in entire files because of this. I had not compiled files or #ifdef'ed out the entire logic. Not gong to fly anymore. Remove the #ifdefs from drm-kmod and reduce the diff to upstream and make maintenance easier by having one place to edit and not 117. That's what LinuxKPI is for.

Jun 15 2025, 5:46 PM
wulf requested changes to D50863: LinuxKPI: acpi: provide union [linuxkpi]_acpi_(object|buffer).

General convention in at least drm-kmod is to not redefine ACPICA objects if it is possible. Porting of this code is mostly just a changing of symbol case and adding/removing of underscores. drm-kmod does not even guards these changes with #ifdefs

Jun 15 2025, 5:17 PM
wulf added a comment to D50853: linuxkpi: Add eventfd_*().

@dumbbell FYI. Take a look at https://github.com/lutzbichler/drm-kmod/tree/pr/6.15. It seems that lutzbichler has advanced to drm-kmod v6.15

Jun 15 2025, 4:25 PM
wulf added inline comments to D50853: linuxkpi: Add eventfd_*().
Jun 15 2025, 4:18 PM

Jun 14 2025

wulf added inline comments to D50853: linuxkpi: Add eventfd_*().
Jun 14 2025, 8:13 PM

Jun 9 2025

wulf added a comment to D50315: inotify: Initial revision.

Yep, I messed up and it was still using libinotify's libinotify.h. I've redone the test properly and found that the program starts behaving differently if linked to libinotify.

The test I'm running is

./inotify-test .
touch a
rm a

When not linked with libinotify, I get

a created in watched directory
a was opened
a opened for writing was closed
a delete from watched directory

When linked to libinotify, I only get

a created in watched directory
a deleted from watched directory

I don't think it is worth fixing, because this mess can only arise for 15-CURRENT users that do not recompile their ports after this change hits the tree.

Jun 9 2025, 1:00 PM

Jun 2 2025

wulf added a comment to D50315: inotify: Initial revision.

As I see, libinotify event values were just copied from Linux, so it may have sense to change system ones to make linuxolator support simpler

This is fine for most of the flags, I will change it. libinotify has this weird thing:

37 /* Flags for the parameter of inotify_init1. */                                                                                                                                                                                                                                                                           
38 #define IN_CLOEXEC      02000000        /* Linux x86 O_CLOEXEC */                                                                                                                                                                                                                                                         
39 #define IN_NONBLOCK     00004000        /* Linux x86 O_NONBLOCK */

Some applications will call inotify_init1(O_CLOEXEC) instead of specifying IN_CLOEXEC. In my inotify.h I just defined those flags to be equal, but to preserve compatibility with libinotify we have to support both values. I guess this is best handled in libc.

Jun 2 2025, 2:56 PM

May 31 2025

wulf added a comment to D50315: inotify: Initial revision.

As I see, libinotify event values were just copied from Linux, so it may have sense to change system ones to make linuxolator support simpler

May 31 2025, 9:41 AM
wulf added a comment to D50315: inotify: Initial revision.

Current ABI is not compatible. libinotify events have different values compared with system provided ones.
You must use libinotify header to link with libinotify or change system one to be ABI-compatible.

May 31 2025, 9:28 AM

May 30 2025

wulf accepted D50550: usb: Make ugen_fill_deviceinfo public.

LGTM

May 30 2025, 6:07 AM
wulf accepted D50549: hid.h: Add U2F usage tables constants.

LGTM

May 30 2025, 6:05 AM

May 28 2025

wulf added a comment to D50498: atkbd: fix first keystroke force reset.

@wulf Are you still have concern on the read_kbd_data? If not, I plan to create the patch for merging.

May 28 2025, 12:36 PM

May 23 2025

wulf added a comment to D50498: atkbd: fix first keystroke force reset.

Should we cache read_kbd_data() rather than reread it?

May 23 2025, 8:46 PM
wulf accepted D50498: atkbd: fix first keystroke force reset.
May 23 2025, 8:43 PM

May 19 2025

wulf added a comment to D50315: inotify: Initial revision.
May 19 2025, 2:17 PM

May 17 2025

wulf added a comment to D50315: inotify: Initial revision.

In test "Bugfix tests":

failed: receive IN_ATTRIB for bugst-workdir/1 on hardlink delete
failed: Not receive IN_DELETE_SELF for bugst-workdir/1 on hardlink delete

This one is tricky to fix, I need to think about it.

IIRC IN_DELETE_SELF is generated when the file link number goes from 1 to 0

May 17 2025, 7:25 PM

May 15 2025

wulf committed rG718273db61a5: rtlbtfw(8): Add Mercusys MA530 VID/PID for Realtek 8761BUV (authored by wulf).
rtlbtfw(8): Add Mercusys MA530 VID/PID for Realtek 8761BUV
May 15 2025, 6:19 PM
wulf committed rGd7837cac6f64: rtlbtfw(8): Fix incorrect chunk index overwrap in rtlbt_load_fwfile() (authored by wulf).
rtlbtfw(8): Fix incorrect chunk index overwrap in rtlbt_load_fwfile()
May 15 2025, 6:19 PM
wulf committed rG072e0b158004: iichid(4): Wait for RESET command response while attaching (authored by wulf).
iichid(4): Wait for RESET command response while attaching
May 15 2025, 6:18 PM
wulf committed rG7798b72a9000: iichid(4): Do not send packets read in interrupt handler to hidbus (authored by wulf).
iichid(4): Do not send packets read in interrupt handler to hidbus
May 15 2025, 6:18 PM
wulf committed rG3bd684f0aafe: iichid(4): Read wMaxInputLength bytes over I2C even if we discards data (authored by wulf).
iichid(4): Read wMaxInputLength bytes over I2C even if we discards data
May 15 2025, 6:18 PM
wulf committed rGc58c931e2004: ig4_iic: Allow sleeping if called from iichid interrupt handler. (authored by wulf).
ig4_iic: Allow sleeping if called from iichid interrupt handler.
May 15 2025, 6:18 PM