Committed with a few more cleanups.

Closing this, continuation in https://reviews.freebsd.org/D51568

I understand how you got here, and I do not object to this review.

Ok, I may have overlooked that wrinkle on sx_xlocked(9).

I cant claim much expertise in this area, but I have read the diffs and they look good to me.

To the extent I have looked at this, I'm fine with it.

I'm fine with this.

For reference, this morning I received this abbreviated diff in daily run email:

In D48317#1113021, @jrtc27 wrote:

I do not know what the implications of picking up a different firmware-chosen value here is and whether FreeBSD can in fact cope with it. Do you?

First: I didn't propose the first chunk, Andrew did, and I adopted it to speed things up.

I am going to time out this review due to obvious lack of interest on the part of the reviewers and commit it as proposed.

I seem to have watchdogs only in old 32 bit hardware, so I am unfortunately unable to test this patch.

Ping ?

In D48329#1103242, @pstef wrote:

Scripts shouldn't be using -h.

I think there are two times three questions here:

Changed != to ^ in write-read-back check.

This is a showstopper for Snapdragon Elite support.

This is a showstopper for Snapdragon Elite support...

git diff -U999999

The loop needs about 1000 iterations before the screen is obviously slower.

I'm fine with this now.

As the original author of the watchdog interfaces, I have no objections to this change, but I have not reviewed the diff.

This works on my T14s G6 Snapdragon machine. (when used together with other necessary changes)

For reference: madt_data->dist->Version is 4

I'm fine with this.

and fdcontrol(1)

dont forget fdwrite(1)

I'm all for this, and yes, in 14 please.

IMO the current text does a really bad job at communicating that.

So if I understand your position, what we are trying to say is:

So which is it ?

I think this is OK.