Page MenuHomeFreeBSD
Feed Advanced Search

Jul 17 2019

debdrup added a comment to D20969: Add option to set umask before starting child process.

Since this review touches more than the man-page, you may want to talk to a few commiters about getting it reviewed by them. The easiest way to find people is to look at who touched these files last (ie. via svn/git blame). :)

Jul 17 2019, 12:37 PM

Jun 22 2019

debdrup added a comment to D20315: Add list of valid CPUTYPE flags for arm/arm64 to make.conf example.

Since it's accepted, would it be possible for this diff to go into HEAD?

Jun 22 2019, 9:03 AM · arm64, ARM

May 24 2019

debdrup added a comment to D18339: Add two new options to "ipfw table <NAME> create" to simplify firewall reload.

Is it okay to ask what the status of this is? Because it looks really useful!

May 24 2019, 7:14 AM

May 20 2019

debdrup added a comment to D20315: Add list of valid CPUTYPE flags for arm/arm64 to make.conf example.

I can't help you with a review, but I can certainly remind you that you should probably get some reviewers involved. :)

May 20 2019, 2:21 PM · arm64, ARM

May 19 2019

debdrup added a comment to D20314: Feature request: Add rc.d script for svnliteserve.

I can't review for you, but I think it would be smart if you got some individual reviewers attached instead of just the whole group?
It's a good idea though. :)

May 19 2019, 8:22 AM · rc

Apr 10 2019

debdrup added a comment to D19860: Increase the number of MAC rules, allow limiting mac_portcl use to given GID.

I'm not a commiter, but since this looks like a neat thing to have, may I suggest you get some reviewers added?
One way to find reviewers is to look through the code for who touched these bits (MFU/MRU-like) and then ask them if they want to review it, or send an email to the appropriate mailing list asking for reviewers.

Apr 10 2019, 2:22 PM

Feb 26 2019

debdrup added a comment to D18484: Update the ipfw section in the Handbook: kernel options, ipfw0, configuration.

Out of interest, who's taking care of the commit?

Feb 26 2019, 8:28 PM

Feb 25 2019

debdrup added a comment to D19184: Set process title during zfs send.

I hope this review isn't waiting on my feedback, since I just had a question that was answered. I can't actually review the code.

Feb 25 2019, 10:48 AM

Feb 17 2019

debdrup added a comment to D19184: Set process title during zfs send.

This might be a dumb question, but does the process title change often enough that setproctitle_fast() added in rS335939 should be used?

Feb 17 2019, 11:24 AM

Jan 27 2019

debdrup added a comment to D18696: sysctlmibinfo(3).

Found two things which may need some TLC.

Jan 27 2019, 7:58 PM

Jan 2 2019

debdrup added a comment to D18708: add instructions for SMTP access setup.

Noticed only one thing, otherwise it looks good to me.

Jan 2 2019, 12:04 AM

Dec 21 2018

debdrup added a comment to D18630: gai_strerror() - Update string error messages according to RFC 3493.

Looks good to me.

Dec 21 2018, 7:41 PM
debdrup added a comment to D18484: Update the ipfw section in the Handbook: kernel options, ipfw0, configuration.

Looks Good To Me!

Dec 21 2018, 7:36 PM

Dec 20 2018

debdrup added a comment to D18497: Improve the handbook section about leaf/automatic packages.

I had to double-check i.e vs. eg., and found that it scans, so it looks good to me.

Dec 20 2018, 9:12 PM

Dec 11 2018

debdrup added a member for docs: debdrup.
Dec 11 2018, 10:37 AM

Nov 9 2018

debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Supply a patch that (should) work.

Nov 9 2018, 9:21 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Turns out this revision didn't work, will update with a new diff that fixes it once I get the OK for the change.

Nov 9 2018, 8:05 PM
debdrup added a comment to P235 Maybe a fix for terms not being defined?.

They do, thank you. :)
Nom.

Nov 9 2018, 8:04 PM
debdrup created P235 Maybe a fix for terms not being defined?.
Nov 9 2018, 1:00 PM

Oct 29 2018

debdrup created P234 Build failures from root of doc.
Oct 29 2018, 10:02 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Applied the changes from rene@ after satisfying myself I understand why they were made.

Oct 29 2018, 10:00 PM
debdrup retitled D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod from Add a note about the new DRM graphics drivers available in graphics/drm-kmod to Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.
Oct 29 2018, 6:29 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Added entities properly, sorted alphabetically

Oct 29 2018, 6:25 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Added forward slash on last variablelist tag.

Oct 29 2018, 5:30 PM
debdrup added a comment to D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

I'm really not sure what I'm supposed to do about these entries (nor am I even sure where to add them), because upstream (linux drm/kms stack) doesn't seem to provide these man-pages and I'm not at all capable of writing them.

Oct 29 2018, 5:29 PM

Oct 28 2018

debdrup awarded D17745: Mention yet another FreeBSD advantage a The World Burns token.
Oct 28 2018, 9:29 PM
debdrup added a comment to D17745: Mention yet another FreeBSD advantage.

Looks Good To Me!

Oct 28 2018, 9:26 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Corrected which drivers work for what cards.

Oct 28 2018, 3:57 PM

Oct 27 2018

debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Added amdgpu, and explain that radeonkms and amdgpu are in general used for older and newer graphcs respectively.

Oct 27 2018, 5:52 PM

Oct 25 2018

debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Added missing semicolon.

Oct 25 2018, 1:36 PM

Oct 24 2018

debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Fixed issues pointed out by bcr@

Oct 24 2018, 10:14 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Remove exteneous article.

Oct 24 2018, 7:25 PM
debdrup updated the diff for D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.

Avoid weasel words, in accordance with the documentation primer.

Oct 24 2018, 7:23 PM
debdrup created D17690: Add a note about the new DRM/KMS graphics drivers available in graphics/drm-kmod.
Oct 24 2018, 7:09 PM

Oct 12 2018

debdrup added a comment to D17541: update ZFS to note support of extended attributes.

For posterity's sake, the context of this review is a conversation on Twitter regarding the state of xattr/EA in FreeBSD for ZFS, with a special eye to multi-labels.

Oct 12 2018, 11:16 PM

Oct 4 2018

debdrup added a comment to D17401: Add new counter descriptions to AMD 0x17.

Did you think about getting some reviewers attached for this, as well as fixing the various errors?
The reason I ask is because it doesn't seem like a bad change, but if it's going to go into the tree there's typically some sort of review process.

Oct 4 2018, 6:20 PM
debdrup added a comment to D17375: Remove old COMPAT_FREEBSDn (n = 4, 5, 6, 7, 9) options from the kernel's default config file.

I shan't comment on it on the change itself, but have you considered getting some reviewers attached to this?
Changes to FreeBSD typically don't land automatically, and there usually has to be at least some sort of review process.

Oct 4 2018, 6:17 PM