In D29586#688941, @skozlov wrote:

• Please check using rclint as well

You absolutely rock- I didn't see that when I looked before, thank you!

Thanks for the review!

I'll take a look at that.

With due attention to @rpokola 's comment above, great.

Comments inline.

A couple of suggestions inline.

PR: ports/25762

Docs are fine, let's see what core says :)

Docs changes are fine, if doceng is happy too.

Remove doc-committers in favour of voluntary docs reviewers.

I don't think this really needs core review either!

Please don't use the -committers 'teams' for review.

Indeed there is, thanks. We'll just use that.

I don't really think portmgr or I need to really approve this :) Thanks for doing it.

So I can close it

@ler I plan to commit this on Thursday or shortly afterwards-- please let me know if you object.

@ale I plan to commit this on Thursday or shortly afterwards-- please let me know if you object.

I think the changes are fine, as these are unlikely to change long term.

Minor suggestion that you can accept or reject.

Couple of minor nits-- if they're fixed (or if HTTP is correct above) then fine for manpages.

The content is fine- would you like to rebase it on Asciidoc or would you like me to sort that?

I think this is OK-- it matches the style of "Quick Porting".

I don't think the upheaval or risk of further bugs is worth this-- the code works as-is right now.

Committed.

Mat approved on IRC

Thanks!

I think this should be ready to go- upstream has accepted it. Are you happy with it?

Just get rid of this paragraph entirely, and the header in the sample

Remove OPTIONS and replace with flavour