In D35021#793664, @markj wrote:

In D35021#793662, @wulf wrote:

I have seen frozen screen several times with procstat -kk reporting about a thread spinning in rps_timer(). Will test the patch. Thanks!

Cool, very likely the same problem. I'll wait for you to test before committing.

I have seen frozen screen several times with procstat -kk reporting about a thread spinning in rps_timer(). Will test the patch. Thanks!

In D34840#789553, @hselasky wrote:

I suspect you can just remove the new_status . I think it is some leftover.

This revision is obsolete and should be abandoned. Absolute positioning is supported by hms(4) on FreeBSD 13+

I am talking about obeying of this rule[1]:

LGTM. But I would prefer to perform some measurements to properly scale pressure value. Or just drop it.

Ouch. Actually, the macro should be named as BCM5974_LE2H rather than WSP_LE2H to follow style. I'll handle that.

LGTM

Ports tree is updated. Please commit rest of your work.

It looks that sx lock suits our needs better than rw here.

will not break package building.

I created PR to handle drm-devel-kmod breakage: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261937

I was able to successfully build drm-kmod with in-base linux/pm_qos.h from D34234 and linux/uuid.h from D34235 after applying of following patch:

diff --git a/sys/compat/linuxkpi/common/include/linux/pm_qos.h b/sys/compat/linuxkpi/common/include/linux/pm_qos.h
index a4512657889..6b9d48c5be6 100644
--- a/sys/compat/linuxkpi/common/include/linux/pm_qos.h
+++ b/sys/compat/linuxkpi/common/include/linux/pm_qos.h
@@ -30,6 +30,8 @@
 #ifndef	_LINUXKPI_LINUX_PM_QOS_H
 #define	_LINUXKPI_LINUX_PM_QOS_H

In D34234#775061, @bz wrote:

I'll go and test that out then; what about D34235 ?
That might need an upfront change like (just drawn up without thinking)?
{{{

• a/linuxkpi/bsd/include/linux/uuid.h

+++ b/linuxkpi/bsd/include/linux/uuid.h
@@ -4,7 +4,10 @@
#define _LINUX_UUID_H

#include <uapi/linux/uuid.h>
+#include_next <linux/uuid.h>

+#ifndef UUID_STRING_LEN
#define UUID_STRING_LEN 36
+#endif

#endif
}}}

Moreover in-base linux/pm_qos.h is hidden from drm-kmod due to dummy include file: https://github.com/freebsd/drm-kmod/blob/master/linuxkpi/dummy/include/linux/pm_qos.h

In D34234#775030, @bz wrote:

Done. How do we coordinate committing all the conflicting bits?

LGTM