Differential D35052

LinuxKPI: Switch irq_work implementation back to standard taskqueue
ClosedPublic
Actions

Authored by wulf on Apr 24 2022, 11:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 17, 11:23 AM

	Unknown Object (File)
	Fri, Oct 17, 4:54 AM

	Unknown Object (File)
	Tue, Oct 14, 10:30 AM

	Unknown Object (File)
	Mon, Oct 13, 7:56 AM

	Unknown Object (File)
	Fri, Oct 10, 7:41 AM

	Unknown Object (File)
	Fri, Oct 10, 3:57 AM

	Unknown Object (File)
	Fri, Oct 10, 1:09 AM

	Unknown Object (File)
	Sep 20 2025, 1:37 AM

Subscribers

Details

Reviewers

• hselasky
manu

Commits

rG185159f77c9c: LinuxKPI: Switch irq_work implementation back to standard taskqueue
rG42c04803d28e: LinuxKPI: Do not use forward declaration for struct llist_node
rGa3e1754f45bf: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue
rG71fe907dfb03: LinuxKPI: Switch irq_work implementation back to standard taskqueue
rGbec4576e4c19: LinuxKPI: Do not use forward declaration for struct llist_node
rGfa30bff5da31: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue

Summary

from fast one as dmabuf does not run callbacks from critical sections
since drm-kmod 5.7.
Consumers which requires fair irq_work like drm-kmod 5.4 must #define
LKPI_IRQ_WORK_USE_FAST_TQ somewhere in source file before linux/irq_work.h
inclusion to enable old behavior.

While here include linux/llist.h to get struct llist_node definition
and add TQFLG_FAILIF_PENDING flag to taskqueue_enqueue to match Linux.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Apr 24 2022, 11:42 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptApr 24 2022, 11:42 PM

wulf requested review of this revision.Apr 24 2022, 11:42 PM

Harbormaster completed remote builds in B45352: Diff 105384.Apr 24 2022, 11:42 PM

Chase for taskqueue_enqueue flag name change

Harbormaster completed remote builds in B45365: Diff 105412.Apr 25 2022, 8:40 PM

TQFLG_FAILIF_PENDING -> TASKQUEUE_FAIL_IF_PENDING

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 12:12 PM

Closed by commit rGfa30bff5da31: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue (authored by wulf). · Explain Why

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rGfa30bff5da31: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue.

wulf added a commit: rGbec4576e4c19: LinuxKPI: Do not use forward declaration for struct llist_node.

wulf added a commit: rG71fe907dfb03: LinuxKPI: Switch irq_work implementation back to standard taskqueue.

wulf added a commit: rGa3e1754f45bf: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue.Jun 1 2022, 9:52 PM

wulf added a commit: rG42c04803d28e: LinuxKPI: Do not use forward declaration for struct llist_node.

wulf added a commit: rG185159f77c9c: LinuxKPI: Switch irq_work implementation back to standard taskqueue.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

6 lines

Diff 106105

sys/compat/linuxkpi/common/include/linux/irq_work.h

Loading...