Did you any performance tests? Can you share results?

In D36309#825545, @pauamma wrote:

Manual page change LGTM and seems consistent with what I think the intent of the rc.subr change is. Can't vouch for the implementation.

Add missing chunk.

I will commit the change next week unless other objections raised.

In D36005#818242, @glebius wrote:

I would aruge that not being able to fabricate PID is a good thing, and the opposite is a security problem. I don't have any strong opinion on this enough to block this change, but I'd like the security people to be aware of it.

In D36005#818242, @glebius wrote:

I would aruge that not being able to fabricate PID is a good thing, and the opposite is a security problem. I don't have any strong opinion on this enough to block this change, but I'd like the security people to be aware of it.

Add more commentaries to parse_tag().

Add another check into parse_tag() for empty ident.

In D36005#817519, @danfe wrote:

Admittedly, first forcibly adding the PID and now providing non-trivial gimmicks to parse the string (what can possibly go wrong, this is C, right? ;-), assuming some particular format, looks pretty bad. I'd much rather respect the LOG_PID and fix those applications that are important enough for us to care, instead of depriving ourselves from flexibility when it's actually needed.

In D36005#817519, @danfe wrote:

Admittedly, first forcibly adding the PID and now providing non-trivial gimmicks to parse the string (what can possibly go wrong, this is C, right? ;-), assuming some particular format, looks pretty bad. I'd much rather respect the LOG_PID and fix those applications that are important enough for us to care, instead of depriving ourselves from flexibility when it's actually needed.

Add another check to parse_tag() for "ident[]" (empty PID).

Corrected previous comment.

To clarify: I ran make buildkernel && make installkernel having *no* MODULES_WITH_WORLD= in /etc/src.conf
and no DEBUG=

I've applied the change to stable/13 manually fixing some rejection and tested it. Works like a charm, thank you. Please commit.

Please merge it to stable/12, too.