LGTM, CC @dim in case he has any extra insight on the two forms.

OK. Discarding errors from $cattool is not directly related to the original issue, right?

From a textcase in the LLVM review that introduced it (https://reviews.llvm.org/D148381):

I was just curious how (and why) this got spotted given it's been sitting there like this for a decade.

I don't know if the code path in drm_encoder_slave.c actually uses this

sure, there is no need to pass in a temporary variable just to discard the result

This LGTM thanks

It's a bit terse, but: https://docs.freebsd.org/en/books/handbook/zfs/#zfs-zfs-set-share

(Do we have something like Klara's https://klarasystems.com/articles/nfs-shares-with-zfs/ in a man page or the Handbook?)

Should we mention something about ZFS here? I guess there should be a high-level section on ZFS/NFS that has a xref to wherever the sharenfs property is documented, and we could have an internal reference to tat section from the "Note well" text.

In general __has_attribute(foo) to check
I think this is fine to get the driver compiling but ought to have a TODO comment

as an aside we should really add memset_explicit to libc and libkern

I'm fine with this version, or with some updates for @imp's notes.

So, the patch will break this, but I think OBS has to be patched anyway...

Note that there is software that parses /dev/sndstat, e.g.
https://github.com/obsproject/obs-studio/blob/6f3f7b4e5a561a02bc0c7cd37260cd7814fba1a9/plugins/oss-audio/oss-input.c#L463

I'm not fully familiar with the xsave details - I'm curious why this was AMD-specific (and/or, what implies that the x87 area was not saved, in the new block)?

See also: D44502

I won't commit this before all dependencies are addressed - mainly I want to get deprecation notices into the tree and MFC'd.

I'm not entirely convinced this dialog should exist at all...

Committed (with typo in Differential Revision, which is why it didn't auto-close)

It seems I haven't proposed a deprecation notice for the fdisk.8 man page yet

makes sense to me. a couple of little notes on phrasing

Would it be excessive to just zero td_frame in MI code?

FYI, if you have reason to upload new patches please include full context (via e.g. git show -U999999) - see https://wiki.freebsd.org/Phabricator for details.

Add .Pp