Page MenuHomeFreeBSD

tzsetup: be explicit about *timezone* abbreviation
ClosedPublic

Authored by emaste on Mar 25 2024, 8:28 PM.
Tags
None
Referenced Files
F82652556: D44500.diff
Wed, May 1, 5:48 AM
Unknown Object (File)
Tue, Apr 30, 2:26 AM
Unknown Object (File)
Fri, Apr 26, 4:29 AM
Unknown Object (File)
Fri, Apr 19, 1:55 PM
Unknown Object (File)
Thu, Apr 18, 3:54 AM
Unknown Object (File)
Tue, Apr 16, 2:19 PM
Unknown Object (File)
Tue, Apr 16, 8:07 AM
Unknown Object (File)
Thu, Apr 11, 7:46 AM
Subscribers

Details

Summary

During the install process tzsetup asks a question like

Does the abbreviation `EDT' look reasonable?

The installer asks lots of questions, some that relate to the previous
screen or topic and some that do not. A new user installed FreeBSD for
the first time and was confused by this question, not realizing that it
was asking whether the abbreviation is correct for the selected
timezone.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
brooks added a subscriber: brooks.

Seems reasonable.

I'm not entirely convinced this dialog should exist at all... Can we really not trust the user to select something from a list? Especially since the consequences of getting it wrong are pretty minor...

This revision is now accepted and ready to land.Mar 25 2024, 8:38 PM

I'm not entirely convinced this dialog should exist at all...

Good point, I think we could just eliminate it (and might take a look at that in the context of more significant installer & related rework). I'll make just this small change for now though for 13 and 14, so that installer screenshots and instructions continue to largely match.

imp added a subscriber: imp.

Agnostic on it's existence... maybe lean for removing it