Page MenuHomeFreeBSD

x86: test the right CPUID bit when checking for XSAVEOPT support
ClosedPublic

Authored by kib on Mar 25 2024, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 7:04 PM
Unknown Object (File)
Wed, Oct 15, 7:04 PM
Unknown Object (File)
Wed, Oct 15, 7:03 PM
Unknown Object (File)
Wed, Oct 15, 8:37 AM
Unknown Object (File)
Sep 7 2025, 4:31 PM
Unknown Object (File)
Sep 7 2025, 7:06 AM
Unknown Object (File)
Sep 6 2025, 10:10 PM
Unknown Object (File)
Sep 4 2025, 12:07 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Mar 25 2024, 1:54 PM
emaste added inline comments.
sys/amd64/amd64/fpu.c
241

possibly CPUID_EXTSTATE_XSAVEOPT should be renamed also (avoiding EXTSTATE)?

(it looks like Linux has a single namespace for all of the CPUID data and calls this bit X86_FEATURE_XSAVEOPT)

This revision is now accepted and ready to land.Mar 25 2024, 5:29 PM
sys/amd64/amd64/fpu.c
241

EXTSTATE designates the different word from CPUID. Linux' X86_FEATURE are not CPUID bits, they are calculated software bits.