Paths

Table of Contentst

Differential D44497

x86: test the right CPUID bit when checking for XSAVEOPT support
ClosedPublic
Actions

Authored by kib on Mar 25 2024, 1:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 8, 6:04 PM

	Unknown Object (File)
	Tue, May 5, 9:00 AM

	Unknown Object (File)
	Fri, May 1, 11:32 PM

	Unknown Object (File)
	Thu, Apr 30, 5:36 PM

	Unknown Object (File)
	Wed, Apr 29, 12:07 PM

	Unknown Object (File)
	Tue, Apr 28, 2:26 PM

	Unknown Object (File)
	Tue, Apr 28, 5:30 AM

	Unknown Object (File)
	Mon, Apr 27, 12:44 PM

View All 86 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rG960d151eaa1e: x86: test the right CPUID bit when checking for XSAVEOPT support

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mar 25 2024, 1:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2024, 1:54 PM

kib requested review of this revision.Mar 25 2024, 1:54 PM

kib added a reviewer: emaste.Mar 25 2024, 3:32 PM

emaste accepted this revision.Mar 25 2024, 5:29 PM

emaste added inline comments.

sys/amd64/amd64/fpu.c
241	possibly `CPUID_EXTSTATE_XSAVEOPT` should be renamed also (avoiding `EXTSTATE`)? (it looks like Linux has a single namespace for all of the CPUID data and calls this bit `X86_FEATURE_XSAVEOPT`)

This revision is now accepted and ready to land.Mar 25 2024, 5:29 PM

kib added inline comments.Mar 26 2024, 2:03 AM

sys/amd64/amd64/fpu.c
241	EXTSTATE designates the different word from CPUID. Linux' X86_FEATURE are not CPUID bits, they are calculated software bits.

Closed by commit rG960d151eaa1e: x86: test the right CPUID bit when checking for XSAVEOPT support (authored by kib). · Explain WhyMar 26 2024, 2:09 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG960d151eaa1e: x86: test the right CPUID bit when checking for XSAVEOPT support.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

5 lines

i386/

i386/

8 lines

Diff 136208

sys/amd64/amd64/fpu.c

Loading...

sys/i386/i386/npx.c

Loading...