Page MenuHomeFreeBSD
Feed Advanced Search

Feb 24 2024

rscheff committed rG5e248c23d995: tcp: retain some CC signals outside of kernel scope (authored by rscheff).
tcp: retain some CC signals outside of kernel scope
Feb 24 2024, 8:03 PM
rscheff closed D44066: tcp: retain some CC signals outside of kernel scope.
Feb 24 2024, 8:02 PM
rscheff requested review of D44066: tcp: retain some CC signals outside of kernel scope.
Feb 24 2024, 8:01 PM
rscheff closed D44023: tcp: cubic - restart epoch after RTO.
Feb 24 2024, 4:17 PM
rscheff committed rG038699a8f18a: tcp: cubic - restart epoch after RTO (authored by rscheff).
tcp: cubic - restart epoch after RTO
Feb 24 2024, 4:17 PM
rscheff closed D43957: tcp: provide correct snd_fack on post_recovery.
Feb 24 2024, 4:17 PM
rscheff committed rG40fdc6d25f01: tcp: provide correct snd_fack on post_recovery (authored by rscheff).
tcp: provide correct snd_fack on post_recovery
Feb 24 2024, 4:17 PM
rscheff closed D43838: tcp: use enum for all congestion control signals.
Feb 24 2024, 4:16 PM
rscheff committed rGf74352fbcf15: tcp: use enum for all congestion control signals (authored by rscheff).
tcp: use enum for all congestion control signals
Feb 24 2024, 4:16 PM
rscheff closed D43797: tcp: prevent div by zero in cc_htcp.
Feb 24 2024, 4:16 PM
rscheff committed rG38983d40c18e: tcp: prevent div by zero in cc_htcp (authored by rscheff).
tcp: prevent div by zero in cc_htcp
Feb 24 2024, 4:16 PM

Feb 22 2024

rscheff added a comment to D44023: tcp: cubic - restart epoch after RTO.

I suspect this is not the final patch, but suffices for now to stop excessive inflation of cwnd on the first ACK when transistioning from slow-start to congestion avoidance.
The guidance given was that t_epoch should be reset at the time cc transitions from slow-start to cong-avoidance.
However, I would like to revisit this anew, once the major overhaul in D41715 is in...

Feb 22 2024, 8:33 PM
rscheff updated the diff for D43797: tcp: prevent div by zero in cc_htcp.
  • do max(1, div) instead max(maxseg, cwnd)/div
Feb 22 2024, 4:42 PM
rscheff requested review of D44023: tcp: cubic - restart epoch after RTO.
Feb 22 2024, 4:35 PM
rscheff added a comment to D43797: tcp: prevent div by zero in cc_htcp.

max(div, 1) prior of outer division.

Feb 22 2024, 3:20 PM

Feb 21 2024

rscheff accepted D44000: tcp: Add a new kernel-only TCP_USE_DDP socket option.
Feb 21 2024, 10:04 AM

Feb 18 2024

rscheff requested review of D43957: tcp: provide correct snd_fack on post_recovery.
Feb 18 2024, 11:12 AM
rscheff updated the diff for D41715: tcp: Align cubic cc with rfc9438.
  • rebase main
Feb 18 2024, 11:09 AM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • rebase main
Feb 18 2024, 10:29 AM
rscheff updated the diff for D36303: Implement AccECN option (w/ early assigned option number).
  • rebase main
Feb 18 2024, 10:27 AM
rscheff updated the diff for D42563: tcp: implement ACE-change ACKs.
  • rebase main
Feb 18 2024, 9:16 AM
rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • delta to D43355_sack_after_rto
Feb 18 2024, 9:14 AM
rscheff updated the diff for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
  • rebase to main
Feb 18 2024, 9:11 AM
rscheff updated the diff for D43838: tcp: use enum for all congestion control signals.
  • rebase main
Feb 18 2024, 9:10 AM

Feb 14 2024

rscheff committed rGfcea1cc9711a: tcp: fix RTO ssthresh for non-6675 pipe calculation (authored by rscheff).
tcp: fix RTO ssthresh for non-6675 pipe calculation
Feb 14 2024, 1:58 PM
rscheff closed D43876: tcp: fix RTO ssthresh for non-6675 pipe calculation.
Feb 14 2024, 1:58 PM
rscheff requested review of D43876: tcp: fix RTO ssthresh for non-6675 pipe calculation.
Feb 14 2024, 12:40 PM

Feb 12 2024

rscheff closed D43855: tcp: partially undo D43792.
Feb 12 2024, 9:41 PM
rscheff added a reverting change for rG62d47d73b7eb: tcp: stop timers and clean scoreboard in tcp_close(): rG57e27ff07aff: tcp: partially undo D43792.
Feb 12 2024, 9:41 PM
rscheff committed rG57e27ff07aff: tcp: partially undo D43792 (authored by rscheff).
tcp: partially undo D43792
Feb 12 2024, 9:41 PM
rscheff added a reverting change for D43792: tcp: stop timers and clean scoreboard in tcp_close(): rG57e27ff07aff: tcp: partially undo D43792.
Feb 12 2024, 9:41 PM
rscheff updated the summary of D43855: tcp: partially undo D43792.
Feb 12 2024, 8:18 PM
rscheff abandoned D43825: tcp: stop all timers in tcp_usr_detach().

Better revert to the prior state (with tcp_timer_stop() in tcp_discardcb()) - D43855

Feb 12 2024, 8:17 PM
rscheff requested review of D43855: tcp: partially undo D43792.
Feb 12 2024, 8:10 PM
rscheff added a reverting change for D43792: tcp: stop timers and clean scoreboard in tcp_close(): D43855: tcp: partially undo D43792.
Feb 12 2024, 8:09 PM
rscheff added a reverting change for rG62d47d73b7eb: tcp: stop timers and clean scoreboard in tcp_close(): D43855: tcp: partially undo D43792.
Feb 12 2024, 8:09 PM
rscheff added inline comments to D43838: tcp: use enum for all congestion control signals.
Feb 12 2024, 6:02 PM
rscheff added inline comments to D43838: tcp: use enum for all congestion control signals.
Feb 12 2024, 5:18 PM

Feb 11 2024

rscheff requested review of D43838: tcp: use enum for all congestion control signals.
Feb 11 2024, 6:09 PM
rscheff requested review of D43836: tcp: add asserts and safety in case no CC module is attached.
Feb 11 2024, 5:23 PM
rscheff retitled D43825: tcp: stop all timers in tcp_usr_detach() from tcp: allow only 2msl timer to run past tcp_discardcb() to tcp: stop all timers in tcp_usr_detach().
Feb 11 2024, 11:26 AM
rscheff updated the diff for D43825: tcp: stop all timers in tcp_usr_detach().
  • stop timers instead
Feb 11 2024, 11:23 AM
rscheff updated the diff for D43825: tcp: stop all timers in tcp_usr_detach().
  • split the MPASS checks
Feb 11 2024, 9:55 AM
rscheff requested review of D43825: tcp: stop all timers in tcp_usr_detach().
Feb 11 2024, 12:13 AM

Feb 10 2024

rscheff committed rG62d47d73b7eb: tcp: stop timers and clean scoreboard in tcp_close() (authored by rscheff).
tcp: stop timers and clean scoreboard in tcp_close()
Feb 10 2024, 9:34 AM
rscheff committed rGa8e817cf5c9c: tcp: stop doing superfluous work after sending RST (authored by rscheff).
tcp: stop doing superfluous work after sending RST
Feb 10 2024, 9:34 AM
rscheff committed rG3eeb22cb8194: tcp: clean scoreboard when releasing the socket buffer (authored by rscheff).
tcp: clean scoreboard when releasing the socket buffer
Feb 10 2024, 9:34 AM
rscheff closed D43808: tcp: stop doing superfluous work after sending RST.
Feb 10 2024, 9:34 AM
rscheff closed D43792: tcp: stop timers and clean scoreboard in tcp_close().
Feb 10 2024, 9:34 AM
rscheff closed D43805: tcp: clean scoreboard when releasing the socket buffer.
Feb 10 2024, 9:34 AM

Feb 9 2024

rscheff requested review of D43808: tcp: stop doing superfluous work after sending RST.
Feb 9 2024, 7:52 PM
rscheff updated the summary of D43792: tcp: stop timers and clean scoreboard in tcp_close().
Feb 9 2024, 7:29 PM
rscheff requested review of D43805: tcp: clean scoreboard when releasing the socket buffer.
Feb 9 2024, 7:28 PM
rscheff updated the diff for D43792: tcp: stop timers and clean scoreboard in tcp_close().
  • leave scoreboard for another commit
Feb 9 2024, 7:22 PM
rscheff updated the diff for D43792: tcp: stop timers and clean scoreboard in tcp_close().
  • clear scoreboard in other instances as well
Feb 9 2024, 11:41 AM
rscheff retitled D43792: tcp: stop timers and clean scoreboard in tcp_close() from tcp: stop timers in base stack in tcp_close() to tcp: stop timers and clean scoreboard in tcp_close().
Feb 9 2024, 8:57 AM
rscheff updated the diff for D43792: tcp: stop timers and clean scoreboard in tcp_close().
  • tcp: stop timers and clean scoreboard when in tcp_close()
Feb 9 2024, 8:56 AM

Feb 8 2024

rscheff requested review of D43797: tcp: prevent div by zero in cc_htcp.
Feb 8 2024, 7:47 PM
rscheff committed rG23c4f232478a: tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO (authored by rscheff).
tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO
Feb 8 2024, 7:41 PM
rscheff closed D43653: tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO.
Feb 8 2024, 7:41 PM
rscheff committed rG32a6df57df3e: tcp: calculate ssthresh on RTO according to RFC5681 (authored by rscheff).
tcp: calculate ssthresh on RTO according to RFC5681
Feb 8 2024, 6:55 PM
rscheff closed D43768: tcp: calc ssthresh on RTO according to RFC5681.
Feb 8 2024, 6:55 PM
rscheff committed rG1adab814e813: tcp: use tcp_fixed_maxseg instead of tcp_maxseg in cc modules (authored by rscheff).
tcp: use tcp_fixed_maxseg instead of tcp_maxseg in cc modules
Feb 8 2024, 5:39 PM
rscheff closed D43779: tcp: use tcp_fixed_maxseg instead of tcp_maxseg in cc modules.
Feb 8 2024, 5:39 PM
rscheff requested review of D43792: tcp: stop timers and clean scoreboard in tcp_close().
Feb 8 2024, 1:18 PM

Feb 7 2024

rscheff accepted D43769: TCP LRO: disable mbuf queuing when packet filter hooks are in place.

the hook part looks fine; won't comment on the vnet aspects...

Feb 7 2024, 2:03 PM
rscheff updated the diff for D43768: tcp: calc ssthresh on RTO according to RFC5681.
  • expand rfc5681 rto ssthresh calc to all relevant places.
  • and also in rack
Feb 7 2024, 10:04 AM
rscheff requested review of D43779: tcp: use tcp_fixed_maxseg instead of tcp_maxseg in cc modules.
Feb 7 2024, 9:39 AM
rscheff accepted D43773: RACK, BBR: improve handling of packets dropped by packet filters.

lgtm

Feb 7 2024, 7:56 AM

Feb 6 2024

rscheff requested review of D43768: tcp: calc ssthresh on RTO according to RFC5681.
Feb 6 2024, 9:11 PM

Feb 5 2024

rscheff committed rG9bc48382a5e8: tcp: move cc_post_recovery past snd_una update (authored by rscheff).
tcp: move cc_post_recovery past snd_una update
Feb 5 2024, 11:42 AM

Jan 29 2024

rscheff requested review of D43653: tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO.
Jan 29 2024, 7:19 PM
rscheff updated the diff for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
2- rebase to main
Jan 29 2024, 8:35 AM
rscheff committed rG0b3f9e435f2b: tcp: move cc_post_recovery past snd_una update (authored by rscheff).
tcp: move cc_post_recovery past snd_una update
Jan 29 2024, 8:25 AM
rscheff closed D43520: tcp: move cc_post_recovery past snd_una update.
Jan 29 2024, 8:25 AM
rscheff accepted D43526: libkvm: use correct kvm_arch for powerpc minidumps.

This allows the core to be generated, and kgdb to recognize the it, but I could still not extract useful info thereafter with kgdb (cross platform amd64 / powerpc).

Jan 29 2024, 7:58 AM

Jan 26 2024

rscheff updated the diff for D43520: tcp: move cc_post_recovery past snd_una update.
  • rebase main
Jan 26 2024, 11:22 AM
rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • rebase main
Jan 26 2024, 11:20 AM
rscheff updated the diff for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
  • rebase to main
Jan 26 2024, 2:47 AM
rscheff updated the diff for D42563: tcp: implement ACE-change ACKs.
  • rebase main
Jan 26 2024, 2:16 AM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • rebase main
Jan 26 2024, 2:09 AM
rscheff committed rG2d05a1c81b2c: tcp: commonize check for more data to send, style changes (authored by rscheff).
tcp: commonize check for more data to send, style changes
Jan 26 2024, 12:22 AM
rscheff closed D43539: tcp: style changes.
Jan 26 2024, 12:22 AM

Jan 25 2024

rscheff closed D43560: tcp: improve tcp_ecn by using switch statements and bit-shifting.
Jan 25 2024, 11:19 PM
rscheff committed rGfc262fd3dc0a: tcp: AccECN access ACE field by shifting bits (authored by rscheff).
tcp: AccECN access ACE field by shifting bits
Jan 25 2024, 11:19 PM
rscheff closed D43447: tcp: fix TCPSTAT accounting for SACK.
Jan 25 2024, 10:01 PM
rscheff committed rG0932fb565a08: tcp: fix TCPSTAT accounting for SACK (authored by rscheff).
tcp: fix TCPSTAT accounting for SACK
Jan 25 2024, 10:01 PM
rscheff accepted D43594: tcphpts: convert TCP header fields to host byte order earlier.

no real lro stuff happening in the base stack.

Jan 25 2024, 9:02 PM
rscheff updated the diff for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
  • rebase to main
Jan 25 2024, 2:38 PM

Jan 24 2024

rscheff updated the diff for D43520: tcp: move cc_post_recovery past snd_una update.
  • break lines at 80
  • compact two consecutive if statements into one
Jan 24 2024, 5:09 PM
rscheff closed D43536: tcp: pass maxseg around instead of locally calculating anew.
Jan 24 2024, 4:41 PM
rscheff committed rGc7c325d01de4: tcp: pass maxseg around instead of calculating locally (authored by rscheff).
tcp: pass maxseg around instead of calculating locally
Jan 24 2024, 4:41 PM
rscheff updated the diff for D43560: tcp: improve tcp_ecn by using switch statements and bit-shifting.
  • remove default: when no special action is necessary
  • place statemens after case: in new line
  • add /* FALLTHROUGH */ comments per style(9)
Jan 24 2024, 4:26 PM
rscheff added inline comments to D43536: tcp: pass maxseg around instead of locally calculating anew.
Jan 24 2024, 2:36 PM
rscheff updated the diff for D43536: tcp: pass maxseg around instead of locally calculating anew.
  • properly initialize maxseg again
Jan 24 2024, 2:36 PM

Jan 23 2024

rscheff updated the diff for D43536: tcp: pass maxseg around instead of locally calculating anew.
  • go back to passing a pointer but don't touch body of functions
Jan 23 2024, 7:38 PM
rscheff updated the diff for D43560: tcp: improve tcp_ecn by using switch statements and bit-shifting.
  • remove default case, as falling through and returning is the correct action.
Jan 23 2024, 7:17 PM
rscheff requested review of D43560: tcp: improve tcp_ecn by using switch statements and bit-shifting.
Jan 23 2024, 2:49 PM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • rebase and align
Jan 23 2024, 2:27 PM
rscheff updated the diff for D42563: tcp: implement ACE-change ACKs.
  • rebase to main
Jan 23 2024, 12:41 PM