tcp: fix TCPSTAT accounting for SACK
ClosedPublic
Actions

Authored by rscheff on Jan 13 2024, 4:19 PM.

Details

Reviewers

rrs
thj
tuexen
glebius
cc

Group Reviewers

transport

Commits

rG0932fb565a08: tcp: fix TCPSTAT accounting for SACK

Summary

Move the accounting for SACK retransmitted bytes down
to where the actual length (tcp header options, ip options)
is known. This also prevents calculating the header lengths
twice during output processing by not calling tcp_maxseg()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Jan 13 2024, 4:19 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 13 2024, 4:19 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jan 13 2024, 4:19 PM

Harbormaster completed remote builds in B55423: Diff 132733.Jan 13 2024, 4:19 PM

rscheff mentioned this in D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.Jan 21 2024, 7:25 PM

tuexen accepted this revision.Jan 25 2024, 8:27 PM

This revision is now accepted and ready to land.Jan 25 2024, 8:27 PM

Closed by commit rG0932fb565a08: tcp: fix TCPSTAT accounting for SACK (authored by rscheff). · Explain WhyJan 25 2024, 10:01 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG0932fb565a08: tcp: fix TCPSTAT accounting for SACK.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_output.c

7 lines

Diff 133358

View Options

tcp: fix TCPSTAT accounting for SACKClosedPublicActions