tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO
ClosedPublic
Actions

Authored by rscheff on Jan 29 2024, 7:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 13, 3:38 AM

	Unknown Object (File)
	Mon, Oct 13, 3:37 AM

	Unknown Object (File)
	Mon, Oct 13, 3:37 AM

	Unknown Object (File)
	Sun, Oct 12, 3:43 PM

	Unknown Object (File)
	Fri, Oct 3, 3:29 AM

	Unknown Object (File)
	Sep 17 2025, 5:02 PM

	Unknown Object (File)
	Aug 12 2025, 1:48 PM

	Unknown Object (File)
	Aug 8 2025, 6:13 PM

Subscribers

Details

Reviewers

rrs
tuexen
cc

Group Reviewers

transport

Commits

rG23c4f232478a: tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO

Summary

The implicit assumption of snd_nxt always being larger than
snd_recover is not true after RTO. If that happens, cwnd
would get inflated to ssthresh, which may be much larger
than the current pipe (data in flight).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Jan 29 2024, 7:19 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 29 2024, 7:19 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jan 29 2024, 7:19 PM

Harbormaster completed remote builds in B55692: Diff 133527.Jan 29 2024, 7:19 PM

tuexen accepted this revision.Feb 8 2024, 4:22 PM

This revision is now accepted and ready to land.Feb 8 2024, 4:22 PM

Closed by commit rG23c4f232478a: tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO (authored by rscheff). · Explain WhyFeb 8 2024, 7:41 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG23c4f232478a: tcp: ensure tcp_sack_partialack does not inflate cwnd after RTO.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_sack.c

13 lines

Diff 134022

View Options

tcp: ensure tcp_sack_partialack does not inflate cwnd after RTOClosedPublicActions