tcphpts: convert TCP header fields to host byte order earlier
ClosedPublic
Actions

Authored by tuexen on Jan 25 2024, 8:26 PM.

Details

Reviewers

rscheff
glebius
rrs
gallatin

Group Reviewers

transport

Commits

rG2da45e304dba: TCP LRO: convert TCP header fields to host byte order earlier
rGf30c7d56546b: TCP LRO: convert TCP header fields to host byte order earlier

Summary

Convert TCP header field to host byte order earlier. This is a preparation for adding dtrace hooks in a follow-up commit, which are missing in the code path, where packets are directly queued to the tcpcb.
No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jan 25 2024, 8:26 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 25 2024, 8:26 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jan 25 2024, 8:26 PM

no real lro stuff happening in the base stack.

This revision is now accepted and ready to land.Jan 25 2024, 9:01 PM

Closed by commit rGf30c7d56546b: TCP LRO: convert TCP header fields to host byte order earlier (authored by tuexen). · Explain WhyJan 29 2024, 5:54 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGf30c7d56546b: TCP LRO: convert TCP header fields to host byte order earlier.

tuexen added a commit: rG2da45e304dba: TCP LRO: convert TCP header fields to host byte order earlier.Wed, Apr 17, 1:42 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_lro_hpts.c

7 lines

tcp_stacks/

rack_bbr_common.c

4 lines

Diff 133509

View Options

sys/netinet/tcp_lro_hpts.c