Differential D43797

tcp: prevent div by zero in cc_htcp
ClosedPublic
Actions

Authored by rscheff on Feb 8 2024, 7:47 PM.

Tags

None

Referenced Files

	F156441059: D43797.id134023.diff
	Wed, May 13, 5:32 PM

	F156441035: D43797.id134847.diff
	Wed, May 13, 5:32 PM

	F156441026: D43797.id134929.diff
	Wed, May 13, 5:31 PM

	F156438574: D43797.diff
	Wed, May 13, 5:13 PM

	Unknown Object (File)
	Mon, May 4, 8:43 AM

	Unknown Object (File)
	Mon, May 4, 6:27 AM

	Unknown Object (File)
	Sun, May 3, 8:39 AM

	Unknown Object (File)
	Thu, Apr 30, 6:49 PM

Subscribers

Details

Reviewers

tuexen
glebius
cc

Group Reviewers

Commits

rG6e298c3612da: tcp: prevent div by zero in cc_htcp
rG419848219b40: tcp: prevent div by zero in cc_htcp
rG38983d40c18e: tcp: prevent div by zero in cc_htcp

Summary

Make sure the divident is at least mss. While this
prevents subsequent division by zero, cwnd should
never be smaller than smss.

Bug: 276674

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Feb 8 2024, 7:47 PM

Herald added a reviewer: transport. · View Herald TranscriptFeb 8 2024, 7:47 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Feb 8 2024, 7:47 PM

Harbormaster completed remote builds in B55870: Diff 134023.Feb 8 2024, 7:47 PM

This patch is not fixing the root cause, but mitigating the consequences. I think I have an idea what the root cause is. Let me do some testing tomorrow....

grahamperrin added a subscriber: grahamperrin.Feb 11 2024, 8:01 PM

max(div, 1) prior of outer division.

do max(1, div) instead max(maxseg, cwnd)/div

Harbormaster completed remote builds in B56170: Diff 134847.Feb 22 2024, 4:42 PM

tuexen accepted this revision.Feb 22 2024, 5:08 PM

This revision is now accepted and ready to land.Feb 22 2024, 5:08 PM

Closed by commit rG38983d40c18e: tcp: prevent div by zero in cc_htcp (authored by rscheff). · Explain WhyFeb 24 2024, 4:16 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG38983d40c18e: tcp: prevent div by zero in cc_htcp.

rscheff added a commit: rG419848219b40: tcp: prevent div by zero in cc_htcp.Feb 27 2024, 11:03 AM

rscheff added a commit: rG6e298c3612da: tcp: prevent div by zero in cc_htcp.Feb 28 2024, 12:27 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

cc/

6 lines

Diff 134929

sys/netinet/cc/cc_htcp.c

Loading...