Page MenuHomeFreeBSD

amd64: fix user pt_page accounting
ClosedPublic

Authored by alc on Dec 5 2021, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 9:53 PM
Unknown Object (File)
Mon, May 6, 1:08 PM
Unknown Object (File)
Sun, Apr 28, 10:04 AM
Unknown Object (File)
Apr 1 2024, 2:56 PM
Unknown Object (File)
Mar 28 2024, 8:12 AM
Unknown Object (File)
Mar 11 2024, 3:27 AM
Unknown Object (File)
Feb 14 2024, 4:52 AM
Unknown Object (File)
Dec 20 2023, 4:13 PM
Subscribers

Details

Summary

When a superpage mapping is destroyed and the original page table page containing 4KB mappings that was being held in reserve is deallocated, the pt_page count was not being decremented. Consequentially, the user pt_count would grow over time.

Test Plan

For example, after multiple iterations of "buildworld", I was seeing the following illogical counts:

vm.pmap.kernel_pt_page_count: 2184
vm.pmap.user_pt_page_count: 2280849
vm.pmap.pv_page_count: 106

With this change, I now see:

vm.pmap.kernel_pt_page_count: 2183
vm.pmap.user_pt_page_count: 344
vm.pmap.pv_page_count: 105

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc requested review of this revision.Dec 5 2021, 6:50 PM
alc created this revision.
This revision is now accepted and ready to land.Dec 5 2021, 6:56 PM
This revision was automatically updated to reflect the committed changes.