Page MenuHomeFreeBSD
Differential D32975

tcp: Fix a locking issue
ClosedPublic
Actions

Authored by tuexen on Nov 12 2021, 8:25 PM.
Tags
None
Referenced Files
F111570701: D32975.id98444.diff
Wed, Mar 5, 10:09 AM
Unknown Object (File)
Sun, Feb 9, 9:37 AM
Unknown Object (File)
Fri, Feb 7, 4:13 PM
Unknown Object (File)
Jan 31 2025, 5:49 PM
Unknown Object (File)
Jan 24 2025, 7:25 PM
Unknown Object (File)
Jan 24 2025, 5:42 PM
Unknown Object (File)
Jan 18 2025, 5:39 PM
Unknown Object (File)
Jan 17 2025, 1:54 PM
View All 45 Files
Subscribers
imp
melifaro

Details

Reviewers
rrs
markj
Group Reviewers
transport
Commits
rGdf07bfda67ad: tcp: Fix a locking issue
Summary

INP_WLOCK_RECHECK_CLEANUP() and INP_WLOCK_RECHECK() might return from the function, which would leave a lock held.

This fixes https://syzkaller.appspot.com/bug?id=72b2acf2475d24006a8f1a63f5a10224aeee1c8d

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Nov 12 2021, 8:25 PM
Herald added a reviewer: transport. · View Herald TranscriptNov 12 2021, 8:25 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Nov 12 2021, 8:25 PM
markj accepted this revision.Nov 12 2021, 8:30 PM

Thanks.

sys/netinet/tcp_usrreq.c
2080

You don't need the ptr != NULL check, strictly speaking.

markj mentioned this in D32973: tcp: Fix a lock leak in tcp_congestion().Nov 12 2021, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 12 2021, 9:14 PM
Closed by commit rGdf07bfda67ad: tcp: Fix a locking issue (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGdf07bfda67ad: tcp: Fix a locking issue.

Revision Contents
Changeset List

PathSize
sys/
netinet/
14 lines

Diff 98444

View Options

sys/netinet/tcp_usrreq.c

Loading...