Page MenuHomeFreeBSD
Differential D32973

tcp: Fix a lock leak in tcp_congestion()
AbandonedPublic
Actions

Authored by markj on Nov 12 2021, 7:59 PM.
Tags
None
Referenced Files
F132156143: D32973.id98441.diff
Tue, Oct 14, 6:54 AM
F132156126: D32973.id.diff
Tue, Oct 14, 6:54 AM
F132101593: D32973.diff
Mon, Oct 13, 5:15 PM
Unknown Object (File)
Fri, Sep 26, 11:50 AM
Unknown Object (File)
Aug 23 2025, 2:53 AM
Unknown Object (File)
Aug 6 2025, 1:46 AM
Unknown Object (File)
Aug 2 2025, 9:22 PM
Unknown Object (File)
Jun 29 2025, 8:34 PM
View All 50 Files
Subscribers
imp
melifaro

Details

Reviewers
rrs
tuexen
Group Reviewers
transport
Summary

Fixes: b8d60729deef ("tcp: Congestion control cleanup.")
Reported by: syzbot+b1a888df08efaa7b4bf1@syzkaller.appspotmail.com

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42767
Build 39655: arc lint + arc unit

Event Timeline

markj created this revision.Nov 12 2021, 7:59 PM
Herald added a reviewer: transport. · View Herald TranscriptNov 12 2021, 7:59 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
markj requested review of this revision.Nov 12 2021, 7:59 PM
Harbormaster completed remote builds in B42767: Diff 98441.Nov 12 2021, 7:59 PM
tuexen added a comment.Nov 12 2021, 8:29 PM

I think CC_LIST_RUNLOCK() must also be called when exiting from the function via INP_WLOCK_RECHECK(). Or am I missing something?I looked also at the issue, and expanded the macros. See D32975.

I can abandon my review, but you would need to change yours.

markj abandoned this revision.Nov 12 2021, 8:30 PM

Incomplete, a better patch is in D32975.

markj added a comment.Nov 12 2021, 8:31 PM
In D32973#744353, @tuexen wrote:

I think CC_LIST_RUNLOCK() must also be called when exiting from the function via INP_WLOCK_RECHECK(). Or am I missing something?I looked also at the issue, and expanded the macros. See D32975.

I can abandon my review, but you would need to change yours.

I think your patch is better.

Revision Contents
Changeset List

PathSize
sys/
netinet/
3 lines

Diff 98441

View Options

sys/netinet/tcp_usrreq.c

Loading...