tcp: Fix a lock leak in tcp_congestion()

[markj]

Summary

Fixes: b8d60729deef ("tcp: Congestion control cleanup.")
Reported by: [e-mail]

[tuexen]

I think CC_LIST_RUNLOCK() must also be called when exiting from the function via INP_WLOCK_RECHECK(). Or am I missing something?I looked also at the issue, and expanded the macros. See D32975.

I can abandon my review, but you would need to change yours.

[markj]

Incomplete, a better patch is in D32975.

[markj]

In D32973#744353, @tuexen wrote:

I think CC_LIST_RUNLOCK() must also be called when exiting from the function via INP_WLOCK_RECHECK(). Or am I missing something?I looked also at the issue, and expanded the macros. See D32975.

I can abandon my review, but you would need to change yours.

I think your patch is better.