Page MenuHomeFreeBSD

tcp: Fix a locking issue
ClosedPublic

Authored by tuexen on Nov 12 2021, 8:25 PM.
Tags
None
Referenced Files
F132365436: D32975.diff
Thu, Oct 16, 6:29 AM
Unknown Object (File)
Wed, Oct 15, 3:35 AM
Unknown Object (File)
Wed, Oct 15, 3:35 AM
Unknown Object (File)
Tue, Oct 14, 6:23 PM
Unknown Object (File)
Tue, Oct 14, 6:54 AM
Unknown Object (File)
Sun, Oct 12, 6:40 AM
Unknown Object (File)
Mon, Sep 22, 10:08 PM
Unknown Object (File)
Sat, Sep 20, 1:33 AM
Subscribers

Details

Summary

INP_WLOCK_RECHECK_CLEANUP() and INP_WLOCK_RECHECK() might return from the function, which would leave a lock held.

This fixes https://syzkaller.appspot.com/bug?id=72b2acf2475d24006a8f1a63f5a10224aeee1c8d

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks.

sys/netinet/tcp_usrreq.c
2080

You don't need the ptr != NULL check, strictly speaking.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 12 2021, 9:14 PM
This revision was automatically updated to reflect the committed changes.