Page MenuHomeFreeBSD
Differential D32975

tcp: Fix a locking issue
ClosedPublic
Actions

Authored by tuexen on Nov 12 2021, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 6:29 AM
Unknown Object (File)
Wed, Oct 15, 3:35 AM
Unknown Object (File)
Wed, Oct 15, 3:35 AM
Unknown Object (File)
Tue, Oct 14, 6:23 PM
Unknown Object (File)
Tue, Oct 14, 6:54 AM
Unknown Object (File)
Sun, Oct 12, 6:40 AM
Unknown Object (File)
Mon, Sep 22, 10:08 PM
Unknown Object (File)
Sep 20 2025, 1:33 AM
View All 81 Files
Subscribers
imp
melifaro

Details

Reviewers
rrs
markj
Group Reviewers
transport
Commits
rGdf07bfda67ad: tcp: Fix a locking issue
Summary

INP_WLOCK_RECHECK_CLEANUP() and INP_WLOCK_RECHECK() might return from the function, which would leave a lock held.

This fixes https://syzkaller.appspot.com/bug?id=72b2acf2475d24006a8f1a63f5a10224aeee1c8d

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Nov 12 2021, 8:25 PM
Herald added a reviewer: transport. · View Herald TranscriptNov 12 2021, 8:25 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Nov 12 2021, 8:25 PM
markj accepted this revision.Nov 12 2021, 8:30 PM

Thanks.

sys/netinet/tcp_usrreq.c
2080

You don't need the ptr != NULL check, strictly speaking.

markj mentioned this in D32973: tcp: Fix a lock leak in tcp_congestion().Nov 12 2021, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 12 2021, 9:14 PM
Closed by commit rGdf07bfda67ad: tcp: Fix a locking issue (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGdf07bfda67ad: tcp: Fix a locking issue.

Revision Contents
Changeset List

PathSize
sys/
netinet/
13 lines

Diff 98447

View Options

sys/netinet/tcp_usrreq.c

Loading...